fix: update cloudfront protocol

ttoss · Feb 1, 2022 · 13678cd · 13678cd
1 parent 72c38a6
commit 13678cd
Showing 1 changed file with 13 additions and 7 deletions.
diff --git a/packages/cli/src/deploy/staticApp/staticApp.template.ts b/packages/cli/src/deploy/staticApp/staticApp.template.ts
@@ -892,6 +892,14 @@ const getCloudFrontTemplate = ({
   };
 
   if (acm) {
+    const acmRegex = /^arn:aws:acm:[-a-z0-9]+:\d{12}:certificate\/[-a-z0-9]+$/;
+
+    const acmCertificateArn = acmRegex.test(acm)
+      ? acm
+      : {
+          'Fn::ImportValue': acm,
+        };
+
     /**
      * Add ACM to CloudFront template.
      */
@@ -900,13 +908,11 @@ const getCloudFrontTemplate = ({
         .DistributionConfig,
       Aliases: aliases || { Ref: 'AWS::NoValue' },
       ViewerCertificate: {
-        AcmCertificateArn: /^arn:aws:acm:[-a-z0-9]+:\d{12}:certificate\/[-a-z0-9]+$/.test(
-          acm,
-        )
-          ? acm
-          : {
-              'Fn::ImportValue': acm,
-            },
+        AcmCertificateArn: acmCertificateArn,
+        /**
+         * AWS CloudFront recommendation.
+         */
+        MinimumProtocolVersion: 'TLSv1.2_2021',
         SslSupportMethod: 'sni-only',
       },
     };