Skip to content
This repository was archived by the owner on Jun 28, 2022. It is now read-only.

Commit

Permalink
fix: remove Lambda@Edge" (#38)
Browse files Browse the repository at this point in the history
  • Loading branch information
arantespp authored Feb 23, 2022
1 parent eaa9a20 commit 12a0e8c
Show file tree
Hide file tree
Showing 7 changed files with 76 additions and 1,381 deletions.
2 changes: 1 addition & 1 deletion packages/cli/jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module.exports = {
collectCoverage: true,
coverageThreshold: {
global: {
branches: 34,
branches: 32,
functions: 54,
lines: 59,
statements: 62,
Expand Down
10 changes: 9 additions & 1 deletion packages/cli/src/deploy/cicd/lambdas/ecsTaskReport.handler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,16 +75,24 @@ export const getEcsTaskTags = async ({

const task = tasks?.[0];

console.log({ tasks, cluster, ecsTaskArn });

if (!task) {
return undefined;
}

return task.tags;
} catch {
} catch (error) {
console.error(error);
return undefined;
}
};

getEcsTaskTags({
ecsTaskArn:
'arn:aws:ecs:us-east-1:483684946879:task/CarlinCicdCarlinMonorepo-RepositoryTasksECSCluster-1J6saGT91hCr/f70d559c47804d6383df170712d3e455',
}).then();

/**
* - MainTagFound: means that the main has a tag, so the main pipeline should
* be skipped because the push was only to update versions and changelogs.
Expand Down
10 changes: 0 additions & 10 deletions packages/cli/src/deploy/staticApp/command.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,6 @@ describe('handling methods', () => {
acm: faker.random.word(),
aliases: [faker.random.word()],
cloudfront: true,
csp: {},
gtmId: faker.random.word(),
spa: true,
};

Expand All @@ -92,8 +90,6 @@ describe('handling methods', () => {
acm: faker.random.word(),
aliases: [faker.random.word()],
cloudfront: true,
csp: {},
gtmId: faker.random.word(),
spa: true,
};

Expand Down Expand Up @@ -139,12 +135,6 @@ describe('should set cloudfront', () => {
{
spa: true,
},
{
csp: {},
},
{
gtmId: faker.random.word(),
},
{
acm: 'some string',
},
Expand Down
15 changes: 0 additions & 15 deletions packages/cli/src/deploy/staticApp/command.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,21 +34,6 @@ export const options = {
require: false,
type: 'boolean',
},
csp: {
coerce: (value: any) => {
if (value === 'false') {
return false;
}

return value;
},
describe: 'CSP headers to be added to Lambda@Edge origin response.',
},
'gtm-id': {
describe: 'Id of the GTM container.',
require: false,
type: 'string',
},
'hosted-zone-name': {
required: false,
describe: `Is the name of a Route 53 hosted zone. If this value is provided, ${NAME} creates the subdomains defined on \`--aliases\` option. E.g. if you have a hosted zone named "sub.domain.com", the value provided may be "sub.domain.com".`,
Expand Down
Loading

0 comments on commit 12a0e8c

Please sign in to comment.