fix: pipelines

packages/cli/src/deploy/cicd/lambdas/githubWebhooksApiV1.handler.ts

@@ -103,7 +103,7 @@ webhooks.on(
 );
 
 webhooks.on(['pull_request.closed'], async ({ payload }) => {
-  if (!getPipelines().includes('closed-pr')) {
+  if (!getPipelines().includes('pr')) {
     return;
   }
 

packages/cli/src/deploy/cicd/pipelines.spec.ts

@@ -2,6 +2,6 @@ import * as pipelinesModule from './pipelines';
 
 test('pipelines', () => {
   expect(pipelinesModule.pipelines).toMatchObject(
-    expect.arrayContaining(['pr', 'main', 'tag', 'closed-pr']),
+    expect.arrayContaining(['pr', 'main', 'tag']),
   );
 });

packages/cli/src/deploy/cicd/pipelines.ts

@@ -1,10 +1,10 @@
-export const pipelines = ['pr', 'closed-pr', 'main', 'tag'] as const;
+export const pipelines = ['pr', 'main', 'tag'] as const;
 
 export type Pipelines = typeof pipelines;
 
 export type Pipeline = Pipelines[number];
 
-const executeCommandFile = (pipeline: Pipeline) =>
+const executeCommandFile = (pipeline: Pipeline | 'closed-pr') =>
   `chmod +x ./cicd/commands/${pipeline} && ./cicd/commands/${pipeline}`;
 
 export const getPrCommands = ({ branch }: { branch: string }) => [

packages/cli/src/deploy/staticApp/command.spec.ts

@@ -117,22 +117,9 @@ describe('should set cloudfront', () => {
 
   test('cloudfront must be true', () => {
     const options = [
-      {
-        acm: 'some string',
-      },
-      {
-        acm: faker.random.word(),
-        aliases: [faker.random.word()],
-      },
       {
         cloudfront: true,
       },
-      {
-        csp: {},
-      },
-      {
-        gtmId: faker.random.word(),
-      },
     ];
 
     return expect(testHelper(options, true)).resolves.toBeTruthy();
@@ -152,6 +139,19 @@ describe('should set cloudfront', () => {
       {
         spa: true,
       },
+      {
+        csp: {},
+      },
+      {
+        gtmId: faker.random.word(),
+      },
+      {
+        acm: 'some string',
+      },
+      {
+        acm: faker.random.word(),
+        aliases: [faker.random.word()],
+      },
     ];
 
     return expect(testHelper(options, false)).resolves.toBeTruthy();

packages/cli/src/deploy/staticApp/command.ts

@@ -94,15 +94,6 @@ export const deployStaticAppCommand: CommandModule<
        */
       .middleware(() => {
         AWS.config.region = CLOUDFRONT_REGION;
-      })
-      .middleware((argv: any) => {
-        const { acm, aliases, csp, gtmId } = argv;
-
-        const someDefined = [acm, aliases, csp, gtmId].some((value) => !!value);
-
-        if (someDefined) {
-          argv.cloudfront = true;
-        }
       }),
   handler: ({ destroy, ...rest }) => {
     if (destroy) {