refactor: use doodson arguments tables to calculate values #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: coordinate reference system class crs.py refactor: pass through `VBox` and `HBox` in tools.py
fix: don't have simpler calling of crs class docs: small changes to crs docstrings docs: use private members
chore: include whitespace after commas
docs: started creating a glossary
docs: add more entries to glossary
feat: create arguments coefficients table for minor constituents feat: add function to calculate doodson numbers
refactor: modify table to use original Doodson coefficients fix: flake8 checks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
==========================================
+ Coverage 70.47% 71.19% +0.71%
==========================================
Files 43 46 +3
Lines 9068 9407 +339
Branches 1197 1221 +24
==========================================
+ Hits 6391 6697 +306
- Misses 2318 2342 +24
- Partials 359 368 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
feat: add option to output Cartwright numbers fix: test solve is in class
fix: append None if Doodson number can't be calculated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: rename
phase_anglestodoodson_argumentsrefactor: add coordinate reference system class
crs.pyrefactor: pass through
VBoxandHBoxintools.pyrefactor: use mean lunar time as independent variable in arguments
refactor: moved minor arguments calculation into new function
feat: made keyword argument for selecting M1 coefficients
feat: add initial solver for harmonic constants
feat: add function to create arguments coefficients table
feat: create arguments coefficients table for minor constituents
feat: add function to calculate Doodson numbers for #263
docs: add link to TMD3 in Resources.rst
docs: create an initial glossary