Skip to content

Conversation

@tsullivan
Copy link
Owner

@tsullivan tsullivan commented Oct 29, 2025

Summary

Makes the Flyout System truly opt-in by changing the session value default from inherit to never.

Closes elastic#9158.

Why are we making this change?

The default of inherit was problematic. It meant that a flyout with no session value added would automatically become a child if a session flyout is active. This would be a problem in Kibana, where all flyouts currently have no session value. Work would be needed to address the problem by adding session="start" on them to avoid possible bugs, which means the default logic planned would amount to a breaking change.

Screenshots #

Impact to users

QA

Remove or strikethrough items that do not apply to your PR.

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in both MacOS and Windows high contrast modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
    • Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
    • If the changes unblock an issue in a different repo, smoke tested carefully (see Testing EUI features in Kibana ahead of time)
  • Designer checklist
    • If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

@tsullivan tsullivan force-pushed the flyout-system/fix-session-logic branch from 9308ab7 to 7e80d70 Compare October 30, 2025 19:44
@tsullivan
Copy link
Owner Author

Replaced with. elastic#9163

@tsullivan tsullivan closed this Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants