[Flyout System] Make session logic truly opt-in #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes the Flyout System truly opt-in by changing the
sessionvalue default frominherittonever.Closes elastic#9158.
Why are we making this change?
The default of inherit was problematic. It meant that a flyout with no session value added would automatically become a child if a session flyout is active. This would be a problem in Kibana, where all flyouts currently have no session value. Work would be needed to address the problem by adding session="start" on them to avoid possible bugs, which means the default logic planned would amount to a breaking change.
Screenshots #
Impact to users
QA
Remove or strikethrough items that do not apply to your PR.
General checklist
@defaultif default values are missing) and playground toggles