Implement hotreloading for macOS and Windows and other bugfixes #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Markos-Th09
changed the title
Markos-Th09
changed the title
Markos-Th09
force-pushed
the
hotreload
branch
from
7070967
to
efa0d44
Compare
Markos-Th09
changed the title
Markos-Th09
changed the title
|
Thank you for the PR! Unfortunately I do not accept feature implementations as per CONTRIBUTING.md sorry. |
|
I understand. Are you planning to implement hotreloading on other platforms yourself any time soon? |
|
I will extract the bug fixes and typo corrections into a new PR without the hotreloading part |
|
Why did you deny this PR but allowed #81 to be merged, which is clearly also a feature implementation? Is there something I am not understanding correctly from CONTRIBUTING.md? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements hot reloading for macOS and windows
Closes #45
Closes #73