Add the unary minus #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the unary minus was added by adding a new Expr and enum called UnOp (short for Unary Operator). `parse_binary_operator` was also renamed to `parse_impl` since it now parses both binary and unary operators
adding unary operators to the pattern matching code was easier than i thought! thanks zozi for the gud cood the unary minus ended up being pretty intuitive to use, but there are some things that are both weird to use and hard to fix. for instance, by making it so -1^2 = -(1^2), it also makes it so -1 + 2 = -(1 + 2). i already tried to fix that but it turned into a mess
so it turns out that making the unary minus part of `Op` actually works better than putting it into a separate `UnOp` and makes it easier to give it the correct precedence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a unary minus can be thought of as a subtraction with only a right hand side expression (so
-1can be thought of asNone - 1. because of that, to implement the unary minus, thelhsfield of theOpinExprwas made optional