Develop -> Main #157

tsmarvin · 2025-08-08T07:59:46Z

No description provided.

…-develop workflow (#155)

…oss all themes, implement dynamic DST handling in date selector, implement comprehensive WCAG AAA accessibility testing suite (#123)

Copilot

Pull Request Overview

This is a comprehensive feature merge from the develop branch to main that significantly enhances the timezone application's functionality and compliance. The PR introduces advanced DST transition handling, comprehensive accessibility compliance testing for WCAG AAA standards, and several critical infrastructure improvements.

DST-aware timezone calculations that dynamically adjust timezone offsets based on selected date
Comprehensive accessibility testing framework covering all screen sizes, themes, and WCAG AAA compliance
Enhanced build process with version management improvements for main branch deployments

Reviewed Changes

Copilot reviewed 10 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
vitest.config.ts	Adds test timeout configurations and single-threaded testing to handle accessibility tests
test/setup.ts	Updates test setup to use built HTML from dist directory with improved mocking
test/dst-transitions.test.ts	New comprehensive DST transition testing covering timezone offset calculations
test/deploy-version.test.ts	New version behavior validation tests for main/develop branch differences
test/accessibility-comprehensive.test.ts	New comprehensive WCAG AAA accessibility testing framework
src/styles/styles.css	Extensive styling improvements with accessibility compliance and theme enhancements
src/scripts/index.ts	Major refactoring to support date-aware timezone calculations and DST handling
src/index.html	HTML accessibility improvements with proper labeling and semantic structure
package.json	Updates test command to build before testing and adds accessibility testing dependencies
.github/workflows/deploy-develop.yml	Improves version handling for main branch builds

Copilot · 2025-08-08T08:01:20Z

test/setup.ts


 /**
- * Load the actual HTML from the site for testing
+ * Load the actual HTML from the built site for testing
 */
 export function loadActualHTML(): void {
-  const htmlPath = join(process.cwd(), 'src', 'index.html');
+  const htmlPath = '/home/runner/work/EveryTimeZone/EveryTimeZone/dist/index.html';


The hardcoded absolute path '/home/runner/work/EveryTimeZone/EveryTimeZone/dist/index.html' is brittle and will break in different environments. Use a relative path or process.cwd() to construct the path dynamically.

Copilot · 2025-08-08T08:01:21Z

src/scripts/index.ts

 }

 const Temporal = window.Temporal;
+const SunCalc = window.SunCalc;


Accessing window.SunCalc without proper null checking could cause runtime errors if the SunCalc library fails to load. Add null checking or fallback handling.

Suggested change

const SunCalc = window.SunCalc;

const SunCalc = typeof window.SunCalc !== "undefined" && window.SunCalc !== null

? window.SunCalc

: null;

Copilot · 2025-08-08T08:01:21Z

test/accessibility-comprehensive.test.ts

+import { readFileSync } from 'fs';
+
+/**
+ * Extract responsive breakpoints from built CSS for accurate testing
+ */
+function extractCSSBreakpoints(): { name: string; width: number; height: number }[] {
+  const cssPath = './dist/styles/styles.css';


The hardcoded path './dist/styles/styles.css' may not exist during test execution, especially if tests run before build. Add existence check or handle FileNotFoundError gracefully.

Suggested change

import { readFileSync } from 'fs';

/**

* Extract responsive breakpoints from built CSS for accurate testing

*/

function extractCSSBreakpoints(): { name: string; width: number; height: number }[] {

const cssPath = './dist/styles/styles.css';

import { readFileSync, existsSync } from 'fs';

/**

* Extract responsive breakpoints from built CSS for accurate testing

*/

function extractCSSBreakpoints(): { name: string; width: number; height: number }[] {

const cssPath = './dist/styles/styles.css';

if (!existsSync(cssPath)) {

// File does not exist; return empty array or handle as appropriate

// Optionally, you could throw a custom error instead

return [];

}

Copilot · 2025-08-08T08:01:21Z

src/scripts/index.ts

+    return actualUTC >= sunTimes.sunrise && actualUTC <= sunTimes.sunset;
+  } catch (error) {
    // Fallback to simple calculation if SunCalc fails
+    console.warn(`SunCalc failed for timezone ${timezone.iana}:`, error);


[nitpick] Console.warn statements in production code can clutter logs and may expose internal system information. Consider using a proper logging system or removing verbose logging in production builds.

Suggested change

console.warn(`SunCalc failed for timezone ${timezone.iana}:`, error);

if (typeof process !== 'undefined' && process.env && process.env.NODE_ENV !== 'production') {

console.warn(`SunCalc failed for timezone ${timezone.iana}:`, error);

}

…etween test and implementation (#158)

…ce issues (#163)

…ations (#170)

… and expand modal behavior Co-authored-by: tsmarvin <[email protected]>

…one calculations Update core timezone calculation functions to use Temporal polyfill instead of legacy Date methods: - Replace new Date() with Temporal.Now.instant().epochMilliseconds in default parameters - Update getTimezoneVariations() to use Temporal.PlainDate for creating test dates - Modernize initializeTimezoneData() to use Temporal for June/December dates - Convert getUserTimezone(), getAllTimezonesOrdered(), getGroupedTimezones() to use Temporal - Update generateTimelineHours() and other timezone functions to use Temporal - Maintain backward compatibility by converting Temporal dates to Date objects for Intl.DateTimeFormat All DST timezone selection features continue to work properly with the new temporal-based calculations. Co-authored-by: tsmarvin <[email protected]>

…poral.PlainDate usage Co-authored-by: tsmarvin <[email protected]>

…tation Co-authored-by: tsmarvin <[email protected]>

…ezone parameters Co-authored-by: tsmarvin <[email protected]>

…ds to prevent incorrect offset calculations Co-authored-by: tsmarvin <[email protected]>

Fix DST timezone selection: Add "+" buttons to search, expand modal for timezone choice, and modernize with Temporal API

Copilot AI added 3 commits August 8, 2025 00:46

feat: implement dynamic DST handling in date selector (#140)

24fb26a

fix: separate version injection for main and develop builds in deploy…

f18611c

…-develop workflow (#155)

feat: enhance sunrise/sunset visualizations with distinct styling acr…

b11cad0

…oss all themes, implement dynamic DST handling in date selector, implement comprehensive WCAG AAA accessibility testing suite (#123)

tsmarvin requested a review from Copilot August 8, 2025 08:00

Copilot AI reviewed Aug 8, 2025

View reviewed changes

fix: include temporal polyfill source map to resolve 404 error (#161)

197fdb2

tsmarvin temporarily deployed to github-pages August 8, 2025 23:04 — with GitHub Actions Inactive

Fix CI test failures caused by inconsistent version injection logic b…

8b2ed7f

…etween test and implementation (#158)

tsmarvin temporarily deployed to github-pages August 9, 2025 05:02 — with GitHub Actions Inactive

fix: optimize timezone calculations with caching to resolve performan…

67238f3

…ce issues (#163)

tsmarvin temporarily deployed to github-pages August 9, 2025 23:10 — with GitHub Actions Inactive

fix: sunrise/sunset symbol placement and eliminate duplicate visualiz…

2b56145

…ations (#170)

tsmarvin temporarily deployed to github-pages August 10, 2025 03:50 — with GitHub Actions Inactive

feat: implement off-cycle DST timezone selection feature (#168)

6ec15c0

tsmarvin temporarily deployed to github-pages August 10, 2025 03:51 — with GitHub Actions Inactive

Copilot AI and others added 5 commits August 10, 2025 04:03

Initial plan

e195214

Develop -> copilot/fix-167 (#173)

74bd097

Fix DST timezone selection issues - add "+" buttons to search results…

172131f

… and expand modal behavior Co-authored-by: tsmarvin <[email protected]>

fix: simplify version number insertion into site (#165)

4a3b6c3

tsmarvin temporarily deployed to github-pages August 10, 2025 04:47 — with GitHub Actions Inactive

Copilot AI and others added 5 commits August 10, 2025 05:01

refactor: simplify Date creation patterns and eliminate redundant Tem…

ab8d79b

…poral.PlainDate usage Co-authored-by: tsmarvin <[email protected]>

refactor: replace legacy Date usage with proper Temporal API implemen…

42a0a9f

…tation Co-authored-by: tsmarvin <[email protected]>

fix: correct Temporal API usage for DST calculations using proper tim…

982a750

…ezone parameters Co-authored-by: tsmarvin <[email protected]>

fix: eliminate Date object creation with timezone-specific millisecon…

4adb0db

…ds to prevent incorrect offset calculations Co-authored-by: tsmarvin <[email protected]>

Merge pull request #172 from tsmarvin/copilot/fix-167

da920c3

Fix DST timezone selection: Add "+" buttons to search, expand modal for timezone choice, and modernize with Temporal API

tsmarvin temporarily deployed to github-pages October 12, 2025 04:47 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Develop -> Main #157

Develop -> Main #157

Uh oh!

tsmarvin commented Aug 8, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 8, 2025

Uh oh!

Copilot AI Aug 8, 2025

Uh oh!

Copilot AI Aug 8, 2025

Uh oh!

Copilot AI Aug 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-const SunCalc = window.SunCalc;
+const SunCalc = typeof window.SunCalc !== "undefined" && window.SunCalc !== null
+  ? window.SunCalc
+  : null;

Develop -> Main #157

Are you sure you want to change the base?

Develop -> Main #157

Uh oh!

Conversation

tsmarvin commented Aug 8, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants