Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kastore to development.txt #2304

Merged
merged 1 commit into from
Aug 2, 2024
Merged

add kastore to development.txt #2304

merged 1 commit into from
Aug 2, 2024

Conversation

petrelharp
Copy link
Contributor

Closes #2302.

I'm not sure why this is necessary, actually, as kastore is required by tskit. (But I assume that's just because I don't understand how python package management works.)

Closes #2302.

I'm not sure why this is necessary, actually, as `kastore` is required by `tskit`.
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.03%. Comparing base (590a9d5) to head (a83b7dc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2304   +/-   ##
=======================================
  Coverage   91.03%   91.03%           
=======================================
  Files          20       20           
  Lines       12023    12023           
  Branches     2439     2439           
=======================================
  Hits        10945    10945           
  Misses        595      595           
  Partials      483      483           
Flag Coverage Δ
C 91.03% <ø> (ø)
python 98.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeromekelleher jeromekelleher merged commit 8eb6e5d into main Aug 2, 2024
14 checks passed
@jeromekelleher
Copy link
Member

I don't think the kastore python package is used by tskit, we build the c code for it directly in.

@jeromekelleher jeromekelleher deleted the require_kastore branch August 7, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No module named kastore when following Development guide
2 participants