Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade jest to 25.1 #250

Merged
merged 1 commit into from
Feb 23, 2020
Merged

upgrade jest to 25.1 #250

merged 1 commit into from
Feb 23, 2020

Conversation

pizzacat83
Copy link
Member

うごくといいな

@codecov
Copy link

codecov bot commented Feb 23, 2020

Codecov Report

Merging #250 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #250   +/-   ##
=======================================
  Coverage   27.59%   27.59%           
=======================================
  Files          84       84           
  Lines        6954     6954           
  Branches     1341     1341           
=======================================
  Hits         1919     1919           
  Misses       4390     4390           
  Partials      645      645           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd314ba...52d230b. Read the comment docs.

Copy link
Member

@hakatashi hakatashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

テスト通ってるし良さそう

@pizzacat83 pizzacat83 merged commit 86eedf1 into master Feb 23, 2020
@pizzacat83 pizzacat83 deleted the upgrade-jest branch February 23, 2020 01:37
@pizzacat83
Copy link
Member Author

ちなみにきっかけはcoverage取得がえぐ重いことで,50sec -> 35sec くらいになりました
jestjs/jest#8557

@cookie-s
Copy link
Member

えらい

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants