Conversation
|
@orta I sincerely apologise for the unusually large size of this pull request, but I would really appreciate it if you could review it. I am constantly helped by this repository, so I wanted to resolve all the problems in one go. |
|
Gentle ping |
|
Yeah, sorry, I'm not really into the idea of having to deal with this entire thing being re-written and I/we have to maintain it TBH It's not like this codebase is actively in my head, it's solidly plodding along shipping updates to the json files as they come along |
|
If you don’t have much time to maintain it, I can help! |
|
Most of the changes here are just formatting changes, and the renames to jsonc aren't correct (that's not a file extension that TS accepts for configs). I'm not sure it's worth the churn. I would probably just send the baseUrl fixes separately, the deno upgrades separately, etc. |
7ffcc03 to
e6e7eaf
Compare
Signed-off-by: Sora Morimoto <sora@morimoto.io>
cc9e767 to
e081ceb
Compare
Signed-off-by: Sora Morimoto <sora@morimoto.io>
Signed-off-by: Sora Morimoto <sora@morimoto.io>
…eUrl` in TypeScript 7 Signed-off-by: Sora Morimoto <sora@morimoto.io>
…cripts/generate-recommend.ts` Signed-off-by: Sora Morimoto <sora@morimoto.io>
Signed-off-by: Sora Morimoto <sora@morimoto.io>
|
Thanks for the feedback. I've significantly trimmed down this PR to minimise the diff — the formatting changes,
Happy to split these into separate PRs if that would be easier to review. |
|
Split would be better. This still seems like a smattering of unrelated fixes/changes. It's not clear to me why you've changed the package manager used in this repo at all, either. |
This PR bundles various improvements and fixes accumulated across the project:
Configuration & Compatibility
baseUrlfrom Ember, Nuxt, Remix, and Docusaurus configurations, and update documentation to recommendpathsinsteadrecommended.json: Modernize with current TypeScript best practices, add_versionfieldTooling & Infrastructure
deno.jsonwith JSR imports, update build scripts to Deno 2 APIs (Deno.Command,@std/jsonc,@std/semver, etc.)All changes maintain backwards compatibility for end users, except
recommended.json!Closes #324
Closes #323