Skip to content

Optimistic Rollup of Fixes#342

Open
smorimoto wants to merge 6 commits intotsconfig:mainfrom
smorimoto:fix
Open

Optimistic Rollup of Fixes#342
smorimoto wants to merge 6 commits intotsconfig:mainfrom
smorimoto:fix

Conversation

@smorimoto
Copy link
Contributor

@smorimoto smorimoto commented Dec 26, 2025

This PR bundles various improvements and fixes accumulated across the project:

Configuration & Compatibility

  • TypeScript 7 compatibility: Remove baseUrl from Ember, Nuxt, Remix, and Docusaurus configurations, and update documentation to recommend paths instead
  • Major update to recommended.json: Modernize with current TypeScript best practices, add _version field

Tooling & Infrastructure

  • GitHub Actions upgrades: Update to checkout@v6, setup-node@v6, and setup-deno@v2
  • Test suite migration: Switch from pnpm to npm for simpler CI setup
  • Deno modernization: Add deno.json with JSR imports, update build scripts to Deno 2 APIs (Deno.Command, @std/jsonc, @std/semver, etc.)

All changes maintain backwards compatibility for end users, except recommended.json!


Closes #324
Closes #323

@smorimoto
Copy link
Contributor Author

@orta I sincerely apologise for the unusually large size of this pull request, but I would really appreciate it if you could review it. I am constantly helped by this repository, so I wanted to resolve all the problems in one go.

@smorimoto
Copy link
Contributor Author

Gentle ping

@orta
Copy link
Member

orta commented Feb 14, 2026

Yeah, sorry, I'm not really into the idea of having to deal with this entire thing being re-written and I/we have to maintain it TBH

It's not like this codebase is actively in my head, it's solidly plodding along shipping updates to the json files as they come along

@smorimoto
Copy link
Contributor Author

If you don’t have much time to maintain it, I can help!

@jakebailey
Copy link
Collaborator

Most of the changes here are just formatting changes, and the renames to jsonc aren't correct (that's not a file extension that TS accepts for configs).

I'm not sure it's worth the churn. I would probably just send the baseUrl fixes separately, the deno upgrades separately, etc.

@smorimoto smorimoto force-pushed the fix branch 3 times, most recently from 7ffcc03 to e6e7eaf Compare March 4, 2026 16:38
Signed-off-by: Sora Morimoto <sora@morimoto.io>
@smorimoto smorimoto force-pushed the fix branch 2 times, most recently from cc9e767 to e081ceb Compare March 5, 2026 06:16
Signed-off-by: Sora Morimoto <sora@morimoto.io>
Signed-off-by: Sora Morimoto <sora@morimoto.io>
…eUrl` in TypeScript 7

Signed-off-by: Sora Morimoto <sora@morimoto.io>
…cripts/generate-recommend.ts`

Signed-off-by: Sora Morimoto <sora@morimoto.io>
Signed-off-by: Sora Morimoto <sora@morimoto.io>
@smorimoto
Copy link
Contributor Author

Thanks for the feedback. I've significantly trimmed down this PR to minimise the diff — the formatting changes, .editorconfig addition, and .jsonc renames have all been removed. The remaining changes are now limited to:

  • baseUrl removal for TypeScript 7 compatibility
  • Deno v2 migration (deno.json, updated imports and APIs)
  • CI updates (GitHub Actions versions, pnpm → npm)
  • recommended.json refresh with _version field

Happy to split these into separate PRs if that would be easier to review.

@jakebailey
Copy link
Collaborator

Split would be better. This still seems like a smattering of unrelated fixes/changes. It's not clear to me why you've changed the package manager used in this repo at all, either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove baseUrl from all bases

3 participants