Implement pkce #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
tschbc
commented
Sep 23, 2022
tschbc
commented
- Replaced the manual implementation of OAuth with the openid/AppAuth-Android library.
- Removed IntelliJ IDEA files from source tracking and updated .gitignore
- Updated README
- Migrated to AndroidX
- Updated Gradle and Kotlin versions
- Removed Retrofit dependency
- General code cleanup
Added the entire .idea/ directory to gitignore instead of singular files and removed tracked files from git. These files are automatically generated by IDEA – there's no need to keep them around in source control. Even worse, it can cause weird build issues depending on different dev environments.
Had to increase compileSdkVersion from 26 to 28 for this to work.
Replaces AuthApi and its retrofit implementation using the AppAuth library to handle token requests.
- RedirectActivity now uses activity results for OAuth flow
- Reworked CustomTabsIntent to use non-deprecated features
- RedirectPresenter error checks Intent from result and initiates the
Token exchange inside redirectReceived()
No longer needed – appAuthRedirectScheme in build.gradle replaces it
- Remove unused items - Fix typos - Fix kotlin lint items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.