fix: fix EACCES error on access by root user #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thx! |
tschaub
approved these changes
Oct 28, 2022
|
Thanks, @danielkatz. Your fix is available in the v5.2.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes to fix an error with the
accessfunction what does not implement a check for a root user. To fix this I'm reusing the logic already implemented incanRead,canWriteandcanExecutefunctions (I've also added tests for those cases initem.spec.js).I've added test for the error case to
bindings.spec.js.P.S. Since, there is no mocking library currently used in the project, so i've used a manual method to mock
process.getuidandprocess.getgidfunctions which can easily be replaced by any mocking library.