Clear entry point and filtering

[koppor]

Context: JabRef/jabref#12990

I would like to search for the "important" modifications and hide some.

I imagine a check list of all refactorings, which I can toggle. If on: show in diff overview, if off: do not show in diff overview.

[tsantalis]

@koppor
Do you want the refactorings to be shown in the main page (as the one in the screenshot)
or in each individual diff (refactorings per file)

[koppor]

Do you want the refactorings to be shown in the main page (as the one in the screenshot)

Yes.

Additionally:

for the file-by-file view (This is refactorings per file, isn't it?): below each file

• with the ones grayed-out not appearing in the current diff. The complete list only shows refactorings appearing in the whole diff at all - not all possible diffs
• hovering on one will highlight the respective refactoring(s) above
• hovering on a line will highlight the respective refactoring (maybe?!)

[koppor]

Example for hovering at errors and then jumping in the editor: https://koppor.github.io/explcheck-issues/texmf-dist/tex/generic/namedef/namedef.sty/#e300,w100,w101,w200,w202,w302,w303

Example for filtering:

[pouryafard75]

@tsantalis I read this issue, and I am not sure if this is something that we are planning to cover. Do you have anything in mind?

[tsantalis]

@pouryafard75
Yes, we can do something like the Chrome extension.

List the refactorings in each file-diff (pinned popup) and have links from the refactoring descriptions to the source code.

[tsantalis]

@koppor
There is a Refactorings button under the deleted/added files in the main diff page.
The refactoring descriptions have links to the corresponding individual diff files.

Next step is to add the filters for the refactoring types.

[tsantalis]

@koppor
This is the current version with checkboxes to filter based on refactoring type.

[tsantalis]

@koppor
Is this Refactorings feature helpful?

[koppor]

@koppor Is this Refactorings feature helpful?

A really good start. I am trying it out at operaton/operaton#787 - and I think the list helps me to categorize the changes.

---

Minor thing: Can Java code typographically be distinguished from normal text

Compare

private activateJobExecutor(jobExecutor JobExecutor) : void extracted from public waitForJobExecutorToProcessAllJobs(processEngineConfiguration ProcessEngineConfigurationImpl, maxMillisToWait long, intervalMillis long) : void in class org.operaton.bpm.engine.test.util.JobExecutorHelper

with

private activateJobExecutor(jobExecutor JobExecutor) : void extracted from public waitForJobExecutorToProcessAllJobs(processEngineConfiguration ProcessEngineConfigurationImpl, maxMillisToWait long, intervalMillis long) : void in class org.operaton.bpm.engine.test.util.JobExecutorHelper

with

or

---

The ordering is not quite clear to me - "Variable" and "Method" seem to alternate somehow? - also not sorted by number of occurences.

---

It would be nice if "Modified files" would also be filtered:

---

Not sure, if this is a good idea: Would it be possible to fill the yellow area with the IDs of the refacotrings applied there?

---

I miss a list at a concrete diff

[koppor]

Is the list of refactorings complete?

If yes, this could be a new kind of code review.

• I go through the list from top to bottom
• I click each refactoring. Then, the accordeon opens and shows the diff / refactoring (not yet implemented)
• If i like , i click on "viewed"
• If I don't like, I comment

If the list is not covering all diffs, there could be another view showing the lines not matched by any refactring. This is the new functionality, I really need to look at as reviewer.

[tsantalis]

@koppor
The list of refactorings covers the entire PR.
Clicking on the links gets you to the corresponding diff where the refactoring exists.

Using the back and forward buttons of the browser you can go back and forth from the main page to the diffs, and the Refactorings will remain as you left it before.

[koppor]

@koppor The list of refactorings covers the entire PR. Clicking on the links gets you to the corresponding diff where the refactoring exists.

I think, the implication is in one way: If the PR contains refactorins, they are covered in the list. -- but not: If all refactorings are combined, all diffs are covered.

Eample: JabRef/jabref#13089

Thus, I cannot rely on the list of refactorings for reviewing a PR.

[tsantalis]

@koppor
<code> elements in refactoring description