Repository navigation
Conversation
Security updates cannot patch packages bundled inside npm@12.2.0. Ignore those four names under /tools/publisher while still opening a version-update pull request when a newer npm release is published. Co-authored-by: T.S. <ts-76@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependabot security-update jobs for
/tools/publisherfail on every attempt and will keep failing until npm ships new bundled copies. This adds a scoped.github/dependabot.ymlso those attempts stop, while a version-update pull request still arrives when a newernpmrelease is published.Root cause
tools/publisherpinsnpm@12.2.0, which is the latest npm release. Its lockfile marks these packagesinBundle: trueinside that tarball:undiciip-addressbrace-expansionhttp-cache-semantics4.3.0does not change the max-stale path)Dependabot cannot replace a bundled dependency on its own. The 2026-10-04 jobs for
undici,ip-address, andbrace-expansionended withsecurity_update_not_possible/dependency_still_vulnerable. The same limit applies tohttp-cache-semantics. Those versions are already the accepted publisher risk intools/publisher/risk-scope.json, enforced byscripts/npm-stage.mjs. Upstream bundling work is npm/cli#10088 and npm/cli#10089.What this config does
.github/dependabot.yml.directory: /tools/publisheronly, on the default weekdaydailyschedule.undici,ip-address,brace-expansion, andhttp-cache-semanticsby name.ignorecovers both security updates and version updates.update-typesis not used, because that option does not suppress security updates.npmdependency, so Dependabot still opens a version-update pull request when a newer npm release exists. GitHub's default three-day version-update cooldown still applies; security updates are not on that cooldown.target-branch. That is required for this entry to apply to security updates (Configuring Dependabot security updates).dependabot.yml.Other manifests are unchanged
There was no
dependabot.ymlbefore, so version updates were off everywhere and security updates came only from repository settings.This file does not list:
/package-lock.json)/bun.lockand/ui/bun.lock;ui/has no npm lockfile).github/workflows)Security-update settings apply only when
directorymatches the manifest. Directories that are not in this file keep the default security-update behavior. Adding those ecosystems here would turn version updates on, which this repository does not have today. The ignore rules are limited to/tools/publisher, so they do not affect the already-patched rootbrace-expansionor any other package.Removing the ignores
After a newer npm release is reviewed and its lockfile bundles fixed copies, delete the matching
ignoreentry:undicionce the bundle is >= 6.28.1ip-addressonce the bundle is >= 10.7.1brace-expansiononce the bundle is >= 5.0.12http-cache-semanticsonce that bundled copy is no longer in the accepted set intools/publisher/risk-scope.jsonUpdate
risk-scope.jsonin the same change. If version updates for the publisher'snpmpin are no longer wanted after all four ignores are gone, delete.github/dependabot.yml.Validation
.github/dependabot.ymlparses as YAML and validates against the SchemaStore Dependabot v2 schema (https://json.schemastore.org/dependabot-2.0.json).