Skip to content

Create Frontend Individual Assignment Page#24

Merged
tryyang2001 merged 5 commits into
masterfrom
tryyang/create_frontend_assignment_page
Mar 14, 2024
Merged

Create Frontend Individual Assignment Page#24
tryyang2001 merged 5 commits into
masterfrom
tryyang/create_frontend_assignment_page

Conversation

@tryyang2001
Copy link
Copy Markdown
Owner

Pull Request

Description

Create the frontend page under /assignments/:id route that will display the assignment details with its questions associated. Also created a loading component for ITS, and try to design a logo for the ITS frontend.

Related Issue(s)

Partially completed #3 , will close the issue only after @junhonglow merge his PR for assignment creation form

Screenshots (if applicable)

image

The loading component:
image
(The progress bar has sliding animation FYI, the icon is just created for fun, we can just use the progress bar if the team dislikes the icon design)

Checklist

  • I have checked that the changes included in the PR are intended to merge to master or any destination branch.
  • I have verified that the new changes do not break any existing functionalities, unless the new changes are intended and have approved by the team.
  • I will take care of the merging and delete the side-branch after the PR is merged.

Additional Notes/References

@tryyang2001 tryyang2001 requested a review from WillCWX March 2, 2024 02:18
@junhonglow junhonglow mentioned this pull request Mar 2, 2024
2 tasks
@tryyang2001 tryyang2001 added the FRONTEND Tasks related to front-end development. label Mar 5, 2024
Copy link
Copy Markdown
Collaborator

@WillCWX WillCWX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Though I think we need to standardize whether we want our react components to be
const Component = () => {} or function Component() {}
It is almost the same functionally so there should be some uniformity

@tryyang2001 tryyang2001 merged commit a71da56 into master Mar 14, 2024
@tryyang2001 tryyang2001 deleted the tryyang/create_frontend_assignment_page branch March 14, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FRONTEND Tasks related to front-end development.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants