Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update monitor_dependabot_activity.yml #1

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Conversation

OnFreund
Copy link
Contributor

@OnFreund OnFreund commented Jan 1, 2025

No description provided.

- text: While the Dependabot action is running (might take a few minutes to complete) it will create a bunch of pull requests as it goes.
- text: Keep an eye on [your Pull Requests tab](${user.repository}/pulls) as the dependabot creates them.
- text: Keep an eye on [your Pull Requests tab](${user.repository}/pulls) as dependabot creates them.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 18-19 look like a repetition of 16-17. Do we need all of these?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its two different things, you check the updates that the workflow is running, the workflow creates pull requests, you need to first see that its running and while its running look at the PR tab to see the PR's, when it started running I myself did not know that its async opening PR's, I waited 3 minutes for it to finish, I rather be explicit in telling the user its opening PR's as its running so open your pr tab and find one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that can explain 16 and 18, but 17 and 19 still sounds like duplicates to me

@aloncarmel aloncarmel merged commit 40a13a8 into main Jan 1, 2025
1 check passed
@OnFreund OnFreund deleted the OnFreund-patch-1 branch January 1, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants