Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependency on older version of rich #160

Merged
merged 3 commits into from
Sep 2, 2022
Merged

Fix dependency on older version of rich #160

merged 3 commits into from
Sep 2, 2022

Conversation

javiber
Copy link
Collaborator

@javiber javiber commented Sep 2, 2022 •
edited
Loading

Only tested the latest of rich

As a reference I had some major issues locking the dependencies:

  • poetry 1.1.X takes for ever in locking and ended up running out of RAM
  • poetry 1.2.0 locks dependencies without any issues but doesn't work on python 3.6
  • poetry 1.1.X can't install a lock file generated by 1.2.0

As a result, I ended up hacking the lock file (as described in this thread) to make it work in 1.1.X

@javiber
Allowed newere versions of rich
0e6555c 
Couldn't re-lock dependencies yet
@javiber javiber force-pushed the fix-104 branch 3 times, most recently from 44e73dc to 8358002 Compare September 2, 2022 19:04
@javiber javiber merged commit 5c0ef5d into master Sep 2, 2022
@javiber javiber deleted the fix-104 branch September 2, 2022 20:29
@dekked dekked mentioned this pull request Sep 2, 2022
Closed
@dekked dekked changed the title Fix 104 Fix dependency on older version of rich Sep 7, 2022
javiber added a commit that referenced this pull request Sep 13, 2022
@javiber
Fix 104 (#160)
261b01a 
* Allowed newere versions of rich

Couldn't re-lock dependencies yet

* Locked dependencies

* Hacked lock file to work wiht poetry 1.1
javiber added a commit that referenced this pull request Sep 13, 2022
@javiber
Fix 104 (#160)
3f44d05 
* Allowed newere versions of rich

Couldn't re-lock dependencies yet

* Locked dependencies

* Hacked lock file to work wiht poetry 1.1
@javiber javiber restored the fix-104 branch September 13, 2022 20:30
@javiber javiber deleted the fix-104 branch September 13, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@javiber