Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved image handling #9

Merged
merged 6 commits into from
Mar 22, 2022
Merged

Improved image handling #9

merged 6 commits into from
Mar 22, 2022

Conversation

cliftonc
Copy link
Contributor

@cliftonc cliftonc commented Nov 6, 2021 •
edited
Loading

Working through real world documents the image handling wasn't good enough.

  • This also now parses images that are inline
  • Inline images are appended after the paragraph they were inline (as notion doesnt allow images inside paragraphs)
  • It checks the image type against what notion allows
  • It defaults to the image as text if it is invalid as before
  • Refactored options to allow for more than one
  • Image url parsing / validation can be disabled

@EndBug EndBug self-assigned this Mar 15, 2022
@EndBug EndBug added the enhancement New feature or request label Mar 15, 2022
EndBug
EndBug approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@EndBug EndBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅
I've updated the branch and resolved the merge conflicts, this should be ready to merge

@EndBug EndBug requested a review from marissamarym March 21, 2022 16:39
@marissamarym marissamarym merged commit 0f54b1c into tryfabric:master Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EndBug EndBug EndBug approved these changes

@marissamarym marissamarym Awaiting requested review from marissamarym

Assignees

@EndBug EndBug

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cliftonc @EndBug @marissamarym