Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for simple tables #19

Merged
merged 3 commits into from
Mar 22, 2022
Merged

Add support for simple tables #19

merged 3 commits into from
Mar 22, 2022

Conversation

jok-dev
Copy link
Contributor

@jok-dev jok-dev commented Mar 18, 2022

Adds support for proper simple tables, based on the documentation here: https://developers.notion.com/changelog/simple-table-support

Closes #16

@EndBug EndBug self-assigned this Mar 21, 2022
@EndBug EndBug added the enhancement New feature or request label Mar 21, 2022
@EndBug EndBug changed the title Resolves #16 - Add support for simple tables Add support for simple tables Mar 21, 2022
Copy link
Member

@EndBug EndBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for contributing!
I just left a comment, could you check it out?

src/notion/blocks.ts Show resolved Hide resolved
Markdown tables always have the first row highlighted

Co-authored-by: Federico Grandi <[email protected]>
@jok-dev
Copy link
Contributor Author

jok-dev commented Mar 21, 2022

Good spot, missed that one.

@jok-dev jok-dev requested a review from EndBug March 21, 2022 21:57
Copy link
Member

@EndBug EndBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM ✅

@EndBug EndBug requested a review from marissamarym March 22, 2022 14:09
@marissamarym marissamarym merged commit ee28191 into tryfabric:master Mar 22, 2022
@jok-dev jok-dev deleted the simple-table-support branch March 22, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simple table support
3 participants