Skip to content

feat(cua-driver): expose action names in get_window_state elements - #3617

Merged
injaneity merged 2 commits into
mainfrom
salvage/3377-window-state-actions
Sep 7, 2026
Merged

feat(cua-driver): expose action names in get_window_state elements#3617
injaneity merged 2 commits into
mainfrom
salvage/3377-window-state-actions

Conversation

@injaneity

@injaneity injaneity commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Scope

Salvaged from #3377. Supersedes #3377 at maintainer request so we can regenerate the host-dependent docs on macOS and finish validation without requiring the contributor to obtain a Mac.

Refs #3376. Preserves the macOS contribution salvaged from #2622.

  • expose existing native action names in structured elements on Linux, macOS, and Windows; omit empty lists and filter blank Linux names;
  • preserve capture-only behavior, query projection, and tokenless macOS observation-only results;
  • regenerate reference docs on macOS; generator portability redesign is out of scope.

Progress / validation

Candidate: bd99fba3093bd0c1c991324c1e3feb3517780f60.

  • Cherry-picked fc2160b6223740647189dd6563ee27addae7250d with -x, retained Wangxiaoxiaoa as author using their GitHub noreply identity, preserved Haoqing Wang's coauthor trailer, and recorded both source PRs in commit provenance.
  • Regenerated on native macOS: the net docs change is exactly the actions description in get_window_state, removing the accidental Linux-wide rewrite.
  • PASS: cargo fmt -- --check.
  • PASS on candidate: cargo test -p platform-macos --lib — 363 passed, 0 failed, 2 ignored.
  • PASS: pnpm --dir docs docs:check:cua-driver after regeneration (identical candidate contents).
  • PASS: docs generator unit tests (5), pinned generator-routing assertions, docs hygiene, and internal links.
  • PASS: production docs build (pnpm --dir docs build). Final-head GitHub CI pending. Prior-head contributor attribution and release metadata passed; final-head checks must be inspected before readiness.
  • Full desktop E2E certification has not run. This macOS execution host has no lume on PATH / verified prepared seed available; native unit tests do not substitute for the canonical logged-in, TCC-authorized Lume gate. Windows/Linux canonical desktop results are also still required before readiness under repository guidance.
  • Draft; no bypass or merge performed. Generator portability redesign remains out of scope.

Co-authored-by: Wangxiaoxiaoa 102247755+Wangxiaoxiaoa@users.noreply.github.com
Co-authored-by: Haoqing Wang hqhq1025@users.noreply.github.com

Expose AT-SPI/AX/UIA action names in the structured `elements` array of
`get_window_state` on Linux, macOS, and Windows. The action list is
omitted when empty, and Linux filters blank/whitespace-only names.

macOS observation-only snapshots (`_observation_only`) continue to emit
action names but do not emit `element_token`, since no snapshot is
registered in that path.

Refs #3376. Salvaged from #2622 (macOS).

Co-authored-by: Haoqing Wang <hqhq1025@users.noreply.github.com>
(cherry picked from commit fc2160b)

Salvaged from #3377.
@injaneity
injaneity force-pushed the salvage/3377-window-state-actions branch from b996b64 to 9d2fd50 Compare September 7, 2026 12:54
@injaneity
injaneity marked this pull request as ready for review September 7, 2026 13:07
@injaneity
injaneity requested a review from f-trycua as a code owner September 7, 2026 13:07
@injaneity
injaneity merged commit 7e89120 into main Sep 7, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants