fix(cua-driver): authenticate history requests lazily - #3505
Merged
Conversation
injaneity
force-pushed
the
fix/3347-lazy-history-attestation
branch
from
September 1, 2026 05:23
b05a45e to
1c23f00
Compare
injaneity
temporarily deployed
to
cua-driver-release-signing
September 3, 2026 00:25 — with
GitHub Actions
Inactive
injaneity
temporarily deployed
to
cua-driver-release-signing
September 3, 2026 00:25 — with
GitHub Actions
Inactive
injaneity
force-pushed
the
fix/3347-lazy-history-attestation
branch
from
September 3, 2026 01:24
1c23f00 to
6cf704e
Compare
injaneity
temporarily deployed
to
cua-driver-release-signing
September 3, 2026 01:24 — with
GitHub Actions
Inactive
injaneity
temporarily deployed
to
cua-driver-release-signing
September 3, 2026 01:24 — with
GitHub Actions
Inactive
injaneity
marked this pull request as ready for review
September 3, 2026 01:34
f-trycua
approved these changes
Sep 3, 2026
injaneity
marked this pull request as draft
September 3, 2026 01:44
injaneity
marked this pull request as ready for review
September 3, 2026 01:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
history_controlorhistory_relaunch_stateroot cause
#3347 established that 0.21 moved installed-helper attestation into the macOS Unix-socket accept loop. The exact installed helper then ran five synchronous
codesignsubprocesses before the daemon knew the request method.status --socketperforms a liveness request followed byauthorization_status, so both ordinary connections paid the privileged History cost and the accept loop could not serve another client while attestation ran.scope
This keeps the existing peer path and signature checks unchanged. It separates cheap peer identity capture from expensive verification and selects verification only for the two privileged History methods. It does not add a cache or change
status, which overlaps #3318.The issue reporter supplied the cross-version isolation and identified the eager attestation path that this change corrects.
Fixes #3347.
validation
candidate:
6cf704eef66b1f30ac7befe0771a935ac94f113dcompleted:
cargo fmt --all -- --checkgit diff --checkpending:
status --socketavoidscodesignand completes below the downstream 2-second deadlinelocal focused Rust execution remains unavailable because this Linux workspace lacks
pkg-configand X11 development metadata.