fix(cua-driver): ignore unrelated Wayland cursor teardown - #3403
Closed
f-trycua wants to merge 3 commits into
Closed
fix(cua-driver): ignore unrelated Wayland cursor teardown#3403f-trycua wants to merge 3 commits into
f-trycua wants to merge 3 commits into
Conversation
f-trycua
marked this pull request as ready for review
August 27, 2026 06:18
injaneity
requested changes
Aug 27, 2026
Collaborator
There was a problem hiding this comment.
this seemes to overlap with #3152, which already owns keyed wayland session state, teardown/revival, cursor routing, and the overlay-trail fix. i'd want to avoid duplicate session models, so should we supersede it?
an older shell helper can fail the semantic check and then block the layer-shell fallback, so no visible cursor receives the move. we should choose the backend once in the linux overlay layer and preserve the older helper fallback
f-trycua
added a commit
to jacob-vincent-mink/cua
that referenced
this pull request
Aug 27, 2026
Select one Linux Wayland overlay backend, prefer native layer-shell over an outdated shell helper, and retain that helper when layer-shell is unavailable. Port the visible first-glide and transparent repaint corrections from trycua#3403 into the existing keyed session model. Co-authored-by: Francesco Bonacci <f@trycua.com>
Collaborator
Author
|
Superseded by #3152. Injaneitys review identified overlap with #3152s keyed session model and the need to centralize Wayland backend selection. The unique first-glide/repaint fixes, plus the fallback correction, are consolidated in #3152 commit |
Collaborator
Author
|
Closing as superseded by #3152, where the unique Wayland glide/repaint fixes and centralized backend fallback are now consolidated without duplicating the keyed session model. |
f-trycua
added a commit
that referenced
this pull request
Aug 27, 2026
* fix(cua-driver): isolate Wayland cursors across outputs Create one initialized layer-shell surface per enabled output, preserve independent named-session cursor state, and keep explicit lifecycle revival aligned with the current session contract. Adapted with permission from the focused Wayland overlay commits in spencerbull/cua. Salvaged from #3151 Co-authored-by: Spencer Bull <7035687+spencerbull@users.noreply.github.com> (cherry picked from commit d60f71f) * fix(cua-driver): align Wayland desktop capture and input pixels Normalize native Wayland captures into the reported desktop action frame and expose the real backing scale so screenshot-grounded input and cursor overlays share one coordinate system. Fail closed instead of distorting nonuniform layouts.\n\nRefs #3061.\n\nCo-authored-by: Pagani <33448453+pagan1e@users.noreply.github.com> (cherry picked from commit c0b02d0) * docs(cua-driver): clarify persistent GUI sessions (cherry picked from commit 3e84ef9) * fix(cua-driver): verify Wayland window activation (cherry picked from commit 0bde8d3) * fix(cua-driver): avoid duplicate X11 overlay on Wayland (cherry picked from commit 0a908f0) * fix(cua-driver): suppress X11 overlay on Wayland displays (cherry picked from commit 9042357) (cherry picked from commit 4bf5d22) * fix(cua-driver): keep session cursor visible during Linux input Continued from Spencer Bull's Wayland cursor contribution and its v0.22 forward-port in jacob-vincent-mink#2. Salvaged from #3151 (cherry picked from commit 2f8b49aedeebd5f9c140708593af17bc33e63a4c) (cherry picked from commit 71bb9f1) Co-authored-by: Spencer Bull <7035687+spencerbull@users.noreply.github.com> * fix(cua-driver): preserve user pointer in agent mode Continued from Spencer Bull's Wayland cursor contribution and its v0.22 forward-port in jacob-vincent-mink#2. Salvaged from #3151 (cherry picked from commit 34f2286) Co-authored-by: Spencer Bull <7035687+spencerbull@users.noreply.github.com> * test(cua-driver): align cursor revival with v0.22 state * fix(cua-driver): centralize Wayland cursor backend routing Select one Linux Wayland overlay backend, prefer native layer-shell over an outdated shell helper, and retain that helper when layer-shell is unavailable. Port the visible first-glide and transparent repaint corrections from #3403 into the existing keyed session model. Co-authored-by: Francesco Bonacci <f@trycua.com> * test(cua-driver): capture composed X11 cursor showcase --------- Co-authored-by: Spencer Bull <7035687+spencerbull@users.noreply.github.com> Co-authored-by: Francesco Bonacci <f@trycua.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Omarchy/Hyprland exposed two Wayland cursor-overlay issues:
MoveTo, so the Cua synthetic cursor appeared to jump instead of glide.What changed
CursorKeyand ignore non-active session removal.Validation
cargo test -p platform-linux(macOS host): 16 passed.cargo fmt --manifest-path libs/cua-driver/rust/Cargo.toml --all -- --checkgit diff --check