Skip to content

fix(cua-driver): unify native action scheduling - #3391

Open
injaneity wants to merge 16 commits into
codex/2238-target-scoped-rebindfrom
rfc/3390-state-scoped-observations
Open

fix(cua-driver): unify native action scheduling#3391
injaneity wants to merge 16 commits into
codex/2238-target-scoped-rebindfrom
rfc/3390-state-scoped-observations

Conversation

@injaneity

@injaneity injaneity commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

What changed

Cua Driver used separate code to coordinate desktop actions and text entry. It also kept its own list of tools for each path, so a new tool could miss the right checks.

This pull request replaces that code with one small scheduler. It now:

It also removes the old desktop lock, text-process set, custom cleanup guard, and duplicate tool list.

There are no browser or public API changes.

Refs #3373

Checks

Candidate 4e7bc5b20f567217034b4d0a50d542d67bd65eb0:

  • formatting and diff checks pass;
  • focused tests cover waiting, refusal, cancellation, cleanup, and tool selection; and
  • all 23 reported CI checks pass.

This branch needs to be rebased onto the latest #3373 before merge.

@injaneity injaneity closed this Aug 26, 2026
@injaneity injaneity reopened this Aug 26, 2026
@injaneity
injaneity force-pushed the rfc/3390-state-scoped-observations branch from 554f6de to ed13b3e Compare August 26, 2026 07:54
@injaneity injaneity changed the title docs(cua-driver): propose state-scoped observations fix(cua-driver): serialize complete desktop action observations Aug 26, 2026
@injaneity
injaneity force-pushed the rfc/3390-state-scoped-observations branch from ed13b3e to d7bd829 Compare August 26, 2026 08:10
@injaneity injaneity changed the title fix(cua-driver): serialize complete desktop action observations fix(cua-driver): unify mutable resource scheduling Aug 26, 2026
@injaneity
injaneity force-pushed the rfc/3390-state-scoped-observations branch 2 times, most recently from 34fa6f5 to fec066f Compare August 26, 2026 09:49
@injaneity injaneity closed this Aug 26, 2026
@injaneity injaneity reopened this Aug 26, 2026
@injaneity
injaneity marked this pull request as ready for review August 26, 2026 09:54
@injaneity
injaneity requested a review from f-trycua as a code owner August 26, 2026 09:54
@injaneity
injaneity marked this pull request as draft August 26, 2026 09:56
@injaneity injaneity changed the title fix(cua-driver): unify mutable resource scheduling fix(cua-driver): unify native action scheduling Aug 26, 2026
@injaneity
injaneity force-pushed the rfc/3390-state-scoped-observations branch 3 times, most recently from 821ac0f to 5f1eda2 Compare August 26, 2026 10:23
@injaneity
injaneity force-pushed the rfc/3390-state-scoped-observations branch from 5f1eda2 to fc1f5c4 Compare August 26, 2026 15:41
@injaneity
injaneity marked this pull request as ready for review August 26, 2026 15:55
injaneity and others added 7 commits August 27, 2026 09:23
Keep modality and focus as internal resolver facts. Publish only the window identity needed for logical rebinding, and ignore unrelated foreground changes.

Co-authored-by: Francesco Bonacci <195596869+f-trycua@users.noreply.github.com>
Adapt pi-computer-use’s cheap signal and authoritative AX diff while retaining Cua Driver ownership proof, focus suppression, and typed action accounting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant