fix(cua-driver): clarify Windows window-state coordinates - #3265
Draft
ethanblake4 wants to merge 1 commit into
Draft
fix(cua-driver): clarify Windows window-state coordinates#3265ethanblake4 wants to merge 1 commit into
ethanblake4 wants to merge 1 commit into
Conversation
Author
|
I'm leaving this as draft; it does significantly improve performance on certain scenarios for me, but it seems like a broader architectural change that would need to be applied across platforms which I don't have the capacity for. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: exposes window-relative bounds and screenshot-to action transform for window-relative cua calls (as opposed to current alwaysscreen-relative bounds). Also, excludes UIA rectangles that lie completely outside the window bounds (this was a case I came across in a real app). Validation: cargo test -p platform-windows window_state_coordinates --lib; cargo check -p platform-windows; cargo check -p cua-driver; cargo fmt --all -- --check; git diff --check. Known gap: the generic live protocol test selected an unrelated IslandWindow whose provider hit the existing four-second UIA timeout before structured output.