fix(cua-driver): report Windows tree completeness - #3264
Open
ethanblake4 wants to merge 3 commits into
Open
Conversation
ethanblake4
marked this pull request as ready for review
August 19, 2026 19:49
ethanblake4
marked this pull request as draft
August 19, 2026 19:55
ethanblake4
marked this pull request as ready for review
August 19, 2026 20:43
Collaborator
|
looks good! just a few changes needed:
|
Remove the dead walk_cached compatibility path and its historical max_* aliases instead of wrapping them in WalkState. Collapse the synthetic WalkState bound tests into one table-driven case; query projection stays covered by the WPF harness.
Author
|
thanks @injaneity ! Addressed those issues, does the new test setup look ok? |
Co-authored-by: Zane Chee <44902825+injaneity@users.noreply.github.com>
injaneity
force-pushed
the
windows-tree-completeness
branch
from
August 21, 2026 17:21
64abc9e to
15d7e63
Compare
injaneity
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows,
elements_completeis currently meaningless; it is unconditionally assigned false because the walker does not track whether it hitmax_elementsormax_depth.This PR tracks whether the Windows UIA walk actually skips nodes because of
max_elements,max_depth, cache-request setup, or enumeration failures, and reportselements_completefrom that traversal rather than always false. Query projection does not change underlying completeness; partial MSAA and unusable trees remain conservative.The follow-up removes the dead
walk_cachedcompatibility shim, historical bound aliases, and an unreachable second SAL fallback branch. SAL windows already return through the earlier MSAA path.Validation:
cargo fmt --all -- --checkgit diff --checkcargo test -p platform-windows uia::tests --locked;cargo check -p cua-driver --locked; schema consistency; WPF harness query/completeness row