docs(cua-driver): accept every supported platform in the history event schema - #3223
Merged
Conversation
…t schema
The published Computer History event schema still pins `data.platform` to
`{"const": "macos"}`, which predates the Windows and Linux extension in #3189.
Both adapters emit `"windows"` and `"linux"`, so any consumer validating real
events against the published v0 schema rejects every event produced off macOS.
Observed on Windows with cua-driver 0.20.1-nightly.20260817.31994594712:
"platform": "windows"
`platform_name()` in history_runtime.rs returns exactly one of
`macos | windows | linux`, so the enum mirrors the emitter.
Refs #3189
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data.platformin the published Computer History event schema from{"const": "macos"}to the set the emitter actually producesThe schema predates the Windows/Linux extension in #3189.
platform_name()inhistory_runtime.rsreturns exactly one ofmacos | windows | linux, so any consumer validating real events against the published v0 schema rejects everything produced off macOS.Validation
0.20.1-nightly.20260817.31994594712, which carries"platform": "windows"and previously failed validationenummirrorsplatform_name()exactly, so no value can validate that the emitter cannot produceScope
Documentation only, no product behavior change —
docs:type, non-releasing.The two substantive Windows bugs found in the same investigation are filed separately and are not addressed here: #3220 (history records no action events when the MCP host predates
history enable) and #3221 (ApplicationFrameHost-hosted apps all attribute to the host).Note for reviewers
Opened for review, not merged. The desktop E2E matrix in
AGENTS.mdhas not been run for this change; it is docs-only, so please confirm whether that gate applies before merging.Closes #3222
🤖 Generated with Claude Code