feat(cua-driver)!: remove browser approval tokens - #3185
Merged
Conversation
f-trycua
marked this pull request as ready for review
August 15, 2026 16:10
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
browser-approve,approval_token, the legacy launch flag, temporary approval artifacts, and MCP prepare markersWhy
The file-backed token was a second authorization system that predated runtime-owned permission profiles, manifests, grants, and authorization hosts. Removing it gives every transport the same runtime authorization contract.
Impact
This intentionally removes a public CLI subcommand and MCP input field. Direct isolated-browser callers no longer need to mint or forward a token. Existing-profile callers must use one of the supported runtime authorization paths.
Validation
Final head:
25a96734781086539a5d327e718048d8b82ab597cargo fmt --all -- --checkcargo test -p cua-driver-core -p cua-driver -p cua-driver-sdk -p cua-driver-testkitcargo test -p cua-driver --all-targets --no-run --locked6221b2823903ce323577037bb9dda7adfd5e1101— passed6221b2823903ce323577037bb9dda7adfd5e1101— passed6221b2823903ce323577037bb9dda7adfd5e1101— passed25a96734781086539a5d327e718048d8b82ab597: native 157/157 and installed-browser 18/18, zero failures — passedThe only commit after the Linux/Windows E2E candidate regenerates
mcp-tools.mdx; it does not change executable behavior. macOS ran the final head. A full rerun confirmed an earlier AppKit timing failure was transient.Closes #3184