ci: run the containerdisk guard on every pull request (#3158) - #3163
Open
r33drichards wants to merge 1 commit into
Open
ci: run the containerdisk guard on every pull request (#3158)#3163r33drichards wants to merge 1 commit into
r33drichards wants to merge 1 commit into
Conversation
tests/test_public_containerdisk_refs.py greps every tracked file for the two private ECR repository names, but the workflow that runs it only fired on an eight-entry paths: list. Of the 4261 tracked files the test scans, that list covered 91 — 2.14%. The gap is not theoretical. #3148 touched libs/python/cua-sandbox/cua_sandbox/transport/fleet_cloud.py and libs/python/cua-sandbox/tests/test_pull_secret.py; neither matches any entry (the only cua-sandbox path on the list is the single file tests/live/test_fleet_ephemeral.py), so the guard was skipped, the new test naming cua-server-windows merged, and the violation surfaced as a red check on an unrelated docs PR. #3149 cleaned it up after the fact. Dropping the filter is preferred over extending it because the test's scope is "every tracked file", and any list short of that reintroduces the same class of miss the next time a directory is added. The job is checkout plus one unittest — 0.4s of work locally — and several other ci-*.yml workflows already run unfiltered on every pull request. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3158.
tests/test_public_containerdisk_refs.pyscans every tracked file for the two private ECR repository names. The workflow that runs it fired on an eight-entrypaths:list. The trigger and the scope did not match.How big the gap was
Evaluating the old
paths:globs against the whole tree:And against the files #3148 actually changed:
The only
libs/python/cua-sandboxentry on the list was the single filetests/live/test_fleet_ephemeral.py, so nothing else under that package could ever trigger the guard. That is how thecua-server-windowsreference in #3148 reachedmainand then failed on an unrelated docs PR, fixed after the fact in #3149.Why remove the filter rather than extend it
The test's scope is "every tracked file". Any
paths:list short of- "**"is a second, hand-maintained copy of that scope that drifts the moment a directory is added — exactly the failure being fixed. Removing the filter makes the trigger match the scope by construction.The cost is one checkout plus one unittest:
Several
ci-*.ymlworkflows in this repo already run unfiltered on every pull request (ci-contributor-attribution.yml,ci-release-metadata.yml,ci-cua-driver-installer-compat.yml, …), so this is not a new pattern.Verification
The change to the workflow file matched the old filter too, so this PR alone proves nothing. Evidence comes from #3164: a branch off this one whose only change is under
libs/python/cua-sandbox/**— a path that matched nothing on the old list. The guard ran there and passed:https://github.com/trycua/cua/actions/runs/31748187467 — 11 seconds, including checkout.
The negative case is on the record already:
gh pr checks 3148lists 17 checks and none of them is this guard.A second, unplanned instance of the gap is open right now: #3166 changes only
libs/python/cua-sandbox/**, andgh pr checks 3166does not list this guard at all. That is the same hole #3148 fell through, still open onmain.#3164 is verification only and has been closed; nothing there is meant to merge.
🤖 Generated with Claude Code