fix(cua-driver): preserve named CLI sessions - #3144
Merged
Merged
Conversation
f-trycua
force-pushed
the
agent/fix-cli-session-lifecycle
branch
2 times, most recently
from
August 13, 2026 18:20
85b2aba to
81122b8
Compare
f-trycua
force-pushed
the
agent/fix-cli-session-lifecycle
branch
from
August 13, 2026 18:40
81122b8 to
503fd37
Compare
f-trycua
marked this pull request as ready for review
August 13, 2026 18:56
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The one-shot CLI always minted a disposable transport owner and ended it immediately after every call. Named sessions were attached to that owner, so
start_sessionsucceeded and was then torn down before the next CLI process could inspect or reuse it.User impact
Shell-oriented callers could not follow a named run across CLI calls even though the lifecycle contract supports repeated public session labels.
Fix
Explicit labels now use the daemon-scoped CLI ownership namespace and rely on explicit
end_sessionor idle expiry. Anonymous calls keep their per-call owner and synchronous cleanup.Checks
cargo fmt --all -- --checkcargo test -p cua-driver --test daemon_required_test --lockedcargo test -p cua-driver --bin cua-driver --lockedcargo clippy -p cua-driver --tests --lockedRefs #3007