Skip to content

fix(cua-sandbox): boot Windows Fleet sandboxes with UEFI firmware #3125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r33drichards merged 1 commit into from
Aug 13, 2026
Merged

fix(cua-sandbox): boot Windows Fleet sandboxes with UEFI firmware #3125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions libs/python/cua-sandbox/cua_sandbox/transport/fleet_cloud.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
CyclopsConfiguration,
CyclopsCredentials,
CyclopsTokenProviderConfiguration,
Firmware,
HttpRequest,
OsGymSandboxTemplateSpecBuilder,
OsGymSandboxWarmPoolSpecBuilder,
Expand Down Expand Up @@ -574,6 +575,12 @@ def _template_request(self) -> CreateTemplateRequest:
)
.services(services)
)
# Windows guest disks are built UEFI-only (see registry/qemu_builder.py), and the
# Fleet schema defaults firmware to BIOS, so a Windows image left at the default
# boots SeaBIOS against a GPT/ESP disk and never reaches the readiness probe.
# The local QEMU runtime keys off the same os_type check.
if self._image.os_type == "windows":
vm_template_builder = vm_template_builder.firmware(Firmware.EFI)
if self._cpu is not None:
vm_template_builder = vm_template_builder.cpu_cores(self._cpu)
if self._memory_mb is not None:
Expand Down
13 changes: 13 additions & 0 deletions libs/python/cua-sandbox/tests/test_fleet_cloud_transport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from cua_sandbox.transport import fleet_cloud
from cua_sandbox.transport.fleet_cloud import FleetCloudTransport
from fleet_sdk import (
Firmware,
OsGymSandboxWarmPoolSpecBuilder,
OsGymSandboxWarmPoolStatus,
Pool,
Expand Down Expand Up @@ -88,6 +89,18 @@ def test_default_windows_image_becomes_typed_template_request():
)


def test_windows_image_boots_uefi():
request = FleetCloudTransport(image=Image.windows(), name="demo")._template_request()

assert request.spec.vm_template.firmware == Firmware.EFI


def test_linux_image_leaves_firmware_at_the_schema_default():
request = FleetCloudTransport(image=Image.linux(), name="demo")._template_request()

assert request.spec.vm_template.firmware is None


def test_pool_request_uses_the_single_sandbox_name_and_requested_replicas():
request = FleetCloudTransport(
image=Image.from_registry("registry.example/workspace@sha256:abc"),
Expand Down
Loading