feat(cua-driver): public observe_window_changes opt-out for the post-action window poll - #2691
Closed
milind-soni wants to merge 1 commit into
Closed
feat(cua-driver): public observe_window_changes opt-out for the post-action window poll#2691milind-soni wants to merge 1 commit into
milind-soni wants to merge 1 commit into
Conversation
…action window poll
milind-soni
added a commit
to milind-soni/axstream
that referenced
this pull request
Jul 30, 2026
Socket order: AXSTREAM_DRIVER_SOCK env -> axstream-driver.sock (a locally patched daemon running the observe_window_changes fast path ahead of the upstream release, trycua/cua#2691) -> the standard daemon socket. No configuration needed on machines running the patched driver via launchd. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
milind-soni
added a commit
to milind-soni/axstream
that referenced
this pull request
Aug 8, 2026
…h opt-in only Auto-discovering axstream-driver.sock by filename silently routed to a custom-built binary whose TCC grant broke on every rebuild (new signature = empty grant = permission popup, repeatedly). Default to the socket the user granted; the observe_window_changes fast path stays available via AXSTREAM_DRIVER_SOCK when someone runs a patched daemon on purpose. The speedup returns for everyone with no popups once trycua/cua#2691 merges.
3 tasks
Collaborator
|
closing as superseded by #3373 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior
Every input tool (
click,drag,press_key,type_text,hotkey,scroll) runs a post-action window-change poll (WindowChangeDetector::detect) that early-exits only when a change appears — a quiet action always pays the fullDEFAULT_TIMEOUT(1s). For agent loops that's useful observation; for deterministic callers (macro replay, test harnesses) that already know what the next action expects, it's pure latency on every action.This adds a public, additive, backwards-compatible opt-out: pass
observe_window_changes: falseon any of those tools to skip the poll (the result then omits new-window/foreground-change notes). Omitted ortruekeeps today's behavior exactly. It is deliberately distinct from the transport-reserved_skip_window_change_detection, whichsanitize_reserved_argsstrips from public callers.Validation
public_observe_window_changes_false_skips_polling(asserts the no-poll fast path, with a timing bound) alongside the existing internal-flag test;cargo test -p platform-macos --locked: 242 passed, 0 failed.cargo fmt -p platform-macosclean.press_keyfrom ~1017ms to ~12ms.Known gaps
platform-macos). Windows/Linux parity can follow if the same observation lands there.scope); no config/global variant included to keep the diff focused.🤖 Generated with Claude Code