fix(cua-driver/linux): glide the agent cursor to the desktop-scope click point - #2061
Conversation
…ick point The Linux window-less desktop-scope click warped only the *real* pointer (XTest) and never moved the agent-cursor *overlay* — unlike the macOS/Windows desktop paths, which glide it. So the most visible cursor on screen sat idle wherever it was last, while the click landed elsewhere: a viewer (and a screen recording) sees the cursor "click somewhere else" even though the action is correct (the harness counter does advance). Reuse the existing `overlay_glide_to_for` helper to glide the overlay to (sx,sy) before the XTest click, matching the other platforms. Cosmetic/UX + makes the desktop-scope action legible in recordings. Caught by inspecting the Linux desktop-scope demo recording frame-by-frame. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Linux desktop-scope click path now awaits the cursor overlay glide to the target coordinates before dispatching the desktop click event. ChangesDesktop click overlay order
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Linux visual regression artifactsMatrix jobs now run independently. Download visual artifacts from this workflow run.
|
What
The Linux window-less desktop-scope click warped only the real pointer (XTest) and never moved the agent-cursor overlay — unlike the macOS/Windows desktop paths, which glide it. So the most visible cursor on screen sat idle elsewhere while the click landed on the target: a viewer (and a screen recording) sees the cursor "click somewhere else" even though the action is correct (the harness counter does advance).
Fix
Reuse the existing
overlay_glide_to_forhelper to glide the overlay to(sx, sy)before the XTest click, matching the other platforms.How it was caught
Inspecting the Linux desktop-scope demo recording frame-by-frame — the overlay was parked in the lower-left while the counter advanced via the (warped) real pointer. Pure cosmetic/UX, but it makes the desktop-scope action legible in recordings and consistent across platforms.
Compile-checked via the Linux build in CI (couldn't build platform-linux on the dev Mac).
🤖 Generated with Claude Code
Summary by CodeRabbit