fix(cua-driver)(test-harness): point Windows csprojs at shared/scenarios.json - #2055
Conversation
…ios.json The per-OS harness reorg (#1727) moved `scenarios.json` to `test-harness/shared/`, but the WPF and WinUI3 csprojs still referenced `..\scenarios\scenarios.json` — i.e. `apps/windows/scenarios/`, a directory that no longer exists. A fresh `test-harness/build/windows.ps1` therefore aborts with: MSB3030: Could not copy "...apps/windows/scenarios/scenarios.json" because it was not found. (`windows.ps1` does not stage the file, so nothing papered over it on a clean checkout.) Point both `<None Include>` paths at the real location, `..\..\..\shared\scenarios.json` (verified present + tracked). The `Link="scenarios.json"` + CopyToOutputDirectory still drop it next to the exe where `Scenarios.cs` reads it from `AppContext.BaseDirectory`. Surfaced while build-verifying the harness suite on the Windows VM. Path arithmetic verified from the csproj dirs; runtime build-confirm on Windows is pending the VM's interactive-session/ACL constraints. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe Windows WinUI3 and WPF test harness project files now include ChangesShared scenarios include path
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
The per-OS harness reorg (#1727) moved
scenarios.jsontotest-harness/shared/, but the WPF and WinUI3 csprojs still reference..\scenarios\scenarios.json— i.e.apps/windows/scenarios/, a directory that no longer exists. A freshtest-harness/build/windows.ps1aborts with:windows.ps1doesn't stage the file, so nothing papered over it on a clean checkout. Both<None Include>paths now point at the real, tracked location..\..\..\shared\scenarios.json. TheLink="scenarios.json"+CopyToOutputDirectorystill drop it next to the exe whereScenarios.csreads it fromAppContext.BaseDirectory.How it surfaced
Build-verifying the harness suite on the Windows VM for #2053 — a fresh
windows.ps1failed here; copyingshared/scenarios.jsoninto the stale path unblocked the build, confirming the diagnosis.Verification
Path arithmetic verified from each csproj dir (
..\..\..\shared\scenarios.jsonresolves to the existingtest-harness/shared/scenarios.json). Runtimewindows.ps1build-confirm on the VM is pending its interactive-session/ACL constraints; the change is a mechanical path correction to the independently-confirmed location.🤖 Generated with Claude Code
Summary by CodeRabbit
scenarios.jsonfile from a common location.