Skip to content

fix(cua-driver)(test-harness): point Windows csprojs at shared/scenarios.json - #2055

Merged
f-trycua merged 1 commit into
mainfrom
fix/windows-harness-scenarios-json-path
Jun 27, 2026
Merged

fix(cua-driver)(test-harness): point Windows csprojs at shared/scenarios.json#2055
f-trycua merged 1 commit into
mainfrom
fix/windows-harness-scenarios-json-path

Conversation

@f-trycua

@f-trycua f-trycua commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

What

The per-OS harness reorg (#1727) moved scenarios.json to test-harness/shared/, but the WPF and WinUI3 csprojs still reference ..\scenarios\scenarios.json — i.e. apps/windows/scenarios/, a directory that no longer exists. A fresh test-harness/build/windows.ps1 aborts with:

MSB3030: Could not copy "...apps/windows/scenarios/scenarios.json" because it was not found.

windows.ps1 doesn't stage the file, so nothing papered over it on a clean checkout. Both <None Include> paths now point at the real, tracked location ..\..\..\shared\scenarios.json. The Link="scenarios.json" + CopyToOutputDirectory still drop it next to the exe where Scenarios.cs reads it from AppContext.BaseDirectory.

How it surfaced

Build-verifying the harness suite on the Windows VM for #2053 — a fresh windows.ps1 failed here; copying shared/scenarios.json into the stale path unblocked the build, confirming the diagnosis.

Verification

Path arithmetic verified from each csproj dir (..\..\..\shared\scenarios.json resolves to the existing test-harness/shared/scenarios.json). Runtime windows.ps1 build-confirm on the VM is pending its interactive-session/ACL constraints; the change is a mechanical path correction to the independently-confirmed location.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the Windows test harness apps to use a shared scenarios.json file from a common location.
    • Kept the existing file copy and output behavior unchanged.

…ios.json

The per-OS harness reorg (#1727) moved `scenarios.json` to
`test-harness/shared/`, but the WPF and WinUI3 csprojs still referenced
`..\scenarios\scenarios.json` — i.e. `apps/windows/scenarios/`, a directory
that no longer exists. A fresh `test-harness/build/windows.ps1` therefore
aborts with:

  MSB3030: Could not copy "...apps/windows/scenarios/scenarios.json"
  because it was not found.

(`windows.ps1` does not stage the file, so nothing papered over it on a clean
checkout.) Point both `<None Include>` paths at the real location,
`..\..\..\shared\scenarios.json` (verified present + tracked). The
`Link="scenarios.json"` + CopyToOutputDirectory still drop it next to the exe
where `Scenarios.cs` reads it from `AppContext.BaseDirectory`.

Surfaced while build-verifying the harness suite on the Windows VM. Path
arithmetic verified from the csproj dirs; runtime build-confirm on Windows is
pending the VM's interactive-session/ACL constraints.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercel Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Jun 26, 2026 11:28pm

Request Review

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 22ac6adb-0780-4eba-8e00-6657a1d5cb9d

📥 Commits

Reviewing files that changed from the base of the PR and between 8e2de25 and 1aadda7.

📒 Files selected for processing (2)
  • libs/cua-driver/test-harness/apps/windows/winui3/CuaTestHarness.WinUI3.csproj
  • libs/cua-driver/test-harness/apps/windows/wpf/CuaTestHarness.Wpf.csproj

📝 Walkthrough

Walkthrough

The Windows WinUI3 and WPF test harness project files now include scenarios.json from a shared relative path instead of the previous local path, while keeping the linked file name and output behavior unchanged.

Changes

Shared scenarios include path

Layer / File(s) Summary
Project item path update
libs/cua-driver/test-harness/apps/windows/winui3/CuaTestHarness.WinUI3.csproj, libs/cua-driver/test-harness/apps/windows/wpf/CuaTestHarness.Wpf.csproj
Both project files change the <None> item source for scenarios.json to ..\..\..\shared\scenarios.json and keep the linked name scenarios.json.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 I hopped by the project files with glee,
And found one shared path for the JSON tree.
No bunny fuss, no carrot mess,
Just a tidy link in WinUI3 and WPF.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: updating Windows test-harness csproj references to the shared scenarios.json file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/windows-harness-scenarios-json-path

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@f-trycua
f-trycua merged commit 317cc47 into main Jun 27, 2026
7 checks passed
@f-trycua
f-trycua deleted the fix/windows-harness-scenarios-json-path branch June 27, 2026 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant