refactor(cua-driver-testkit): shared integration-test harness + transport abstraction - #2039
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (12)
📝 WalkthroughWalkthroughAdds a shared ChangesShared testkit crate and core API
Integration test migration
Sequence Diagram(s)sequenceDiagram
participant focus_check_test
participant McpDriver
participant ChildReaper
participant cua_driver as cua-driver
participant ToolResponse
focus_check_test->>McpDriver: McpDriver::spawn()
McpDriver->>ChildReaper: track spawned child
McpDriver->>cua_driver: initialize JSON-RPC over stdio
focus_check_test->>McpDriver: call(tool, args)
McpDriver->>cua_driver: tools/call request
cua_driver-->>McpDriver: JSON-RPC response
McpDriver->>ToolResponse: ToolResponse::from_mcp(raw)
McpDriver-->>focus_check_test: ToolResponse
Estimated review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Linux visual regression artifactsMatrix jobs now run independently. Download visual artifacts from this workflow run.
|
…ests
Introduces crates/cua-driver-testkit — the single home for machinery that was
copy-pasted across tests/ (workspace_root/driver_binary ×9, the JSON-RPC stdio
client ×10, the Windows kill-on-close Job Object reaper ×2, result accessors).
Key design: a Driver trait with two transports — McpDriver (long-lived server,
session-scoped state) and CliDriver (stateless cua-driver call) — that normalize
their differing payloads (the CLI prints structuredContent directly, MCP returns
the JSON-RPC envelope) into one ToolResponse {text(), structured(), is_error()}.
This makes the CLI-vs-MCP transport axis testable instead of MCP-only.
Proof-of-shape migrations (no behavior change):
- focus_check_test.rs (macOS) — verified compiles locally.
- harness_desktop_scope_test.rs (Windows) — drops its whole Job Object +
JSON-RPC block for the testkit; pending Windows compile-verify.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
f-trycua
force-pushed
the
refactor/cua-driver-testkit
branch
from
June 26, 2026 06:10
bb18f12 to
d19ff18
Compare
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on #2038 (base is its branch so the diff is just this refactor). This is PR #1 of the test-suite cleanup — extract the duplicated harness machinery; renames/coverage come in follow-ups.
Why
tests/had no shared module — every file re-implemented the same code:workspace_root()/driver_binary()send/call/init)result_text/is_erroraccessorsWhat
New
crates/cua-driver-testkit(dev-dependency only, never shipped):Drivertrait + two transports —McpDriver(long-lived server, session-scoped state) andCliDriver(statelesscua-driver call). They normalize their different payloads (the CLI printsstructuredContentdirectly; MCP returns the JSON-RPC envelope) into oneToolResponse(text()/structured()/is_error()). This is what makes the CLI-vs-MCP transport axis testable instead of MCP-only.ChildReaper— cross-platform child kill-on-drop; on Windows assigns to aJOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSEjob (no orphaned windows / held ports on panic or SIGKILL).paths— onedriver_binary()(.exeviacfg!),workspace_root(),harness_app().Proof-of-shape migrations (no behavior change)
focus_check_test.rs(macOS) — ✅ compiles locally.harness_desktop_scope_test.rs(Windows) — drops its entire Job Object + JSON-RPC block for the testkit.Verification
cargo test --no-run -p cua-driver --test focus_check_test(testkit + test compile).cargo clean -p cua-driver-testkitthencargo test --no-run --test harness_desktop_scope_test→ recompiles the testkit Windows (Job Object) path,EXIT=0, binary produced.#[ignore](real desktop) — live--ignoredruns unchanged from before.Follow-ups (per the plan): migrate the remaining 11 files, then the 4-family rename, then the coverage matrix +
transport_config_persistence_test.🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Bug Fixes