-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix(cua-driver/linux): report dead input backend on KDE/GNOME Wayland instead of silent no-op (#1982) #1992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Avoid unconditional “unaffected” wording for other capabilities.
Line [299]-Line [300] says
list_windowsand screen capture are unaffected, but this branch also runs whenforeign_toplevel/screencopy/wl_shmare missing. That can mislead diagnosis on compositors missing additional globals.Suggested wording fix
return CheckEntry::fail( NAME_WAYLAND_BACKEND, format!( "Input injection has no backend on this compositor ({msg}): it \ advertises no zwlr_virtual_pointer and this build was compiled \ without libei/portal support, so clicks and key presses will not \ - be delivered (the agent cursor still renders). list_windows and \ - screen capture are unaffected." + be delivered (the agent cursor still renders). list_windows and \ + screen capture depend on foreign-toplevel/screencopy/wl_shm \ + availability." ), "Use the portal-enabled Linux build (compiled with --features \ portal-libei) for input on KDE Plasma / GNOME, or a wlroots \ compositor (sway, labwc, hyprland) where zwlr_virtual_pointer exists.", );📝 Committable suggestion
🤖 Prompt for AI Agents