Skip to content

ci: distro-compat smoke-test matrix for cua-driver linux binary (CUA-599) - #1959

Merged
r33drichards merged 6 commits into
mainfrom
f/cua-599-nixos-cua-driver-test-suite-has-blind-spots-for-real-distro
Jun 21, 2026
Merged

ci: distro-compat smoke-test matrix for cua-driver linux binary (CUA-599)#1959
r33drichards merged 6 commits into
mainfrom
f/cua-599-nixos-cua-driver-test-suite-has-blind-spots-for-real-distro

Conversation

@r33drichards

@r33drichards r33drichards commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

NixOS cua-driver test suite — distro-compat smoke tests

Adds a CI workflow that runs the cua-driver binary inside real Linux distribution containers to catch glibc ABI and dependency issues that NixOS CI misses.

Distros tested

  • debian:12, ubuntu:22.04, ubuntu:24.04, rockylinux:9, fedora:41

Tests

  • cua-driver --version succeeds
  • cua-driver doctor exits without code 127/126 (ABI/linker guard)

Review changes (commit 9a39bd7)

  • Fixed double --version call: removed redundant bare call before VERSION_OUT capture
  • Added binutils: strings requires binutils; added to all 5 distros (apt/dnf)
  • Typo fix: manifstmanifest
  • GHA clarification: added NOTE that path filters are ignored on tag pushes

Follow-up (Linear limit hit — tracked in comments)

  • Add debian:11 (glibc 2.31 floor)
  • Add arm64 matrix jobs
  • Remove continue-on-error: true once stable

@vercel

vercel Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Jun 21, 2026 11:17pm

Request Review

@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d9efabee-ddbd-4846-8fa2-ce4cab5e83a0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

A new GitHub Actions workflow file is added that defines a "CI: cua-driver distro-compat matrix" pipeline. It configures PR/push/dispatch triggers, read-only permissions, and jobs that resolve a driver release version, download and extract the corresponding tarball, then run libc/ABI verification and smoke checks across a distro matrix.

Changes

cua-driver distro-compat CI workflow

Layer / File(s) Summary
Full distro-compat CI workflow
.github/workflows/ci-distro-compat-cua-driver.yml
Introduces the entire workflow: trigger setup (PR, push, workflow_dispatch with optional version input), read-only contents permissions, distro matrix construction, release-version resolution from GitHub release assets/tags, tarball download and extraction, libc/ABI verification, and smoke/documentation matrix checks.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Poem

🐇 A matrix of distros, a tarball to fetch,
The rabbit checks libc with care and finesse.
ABI versions resolved from a tag or release,
Smoke tests ignite, then the workflow finds peace.
Each distro aligned, the CI hops with glee! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and specifically describes the main change: adding a distro-compatibility smoke-test matrix workflow for cua-driver Linux binary testing, with clear reference to the issue (CUA-599).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch f/cua-599-nixos-cua-driver-test-suite-has-blind-spots-for-real-distro

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/ci-distro-compat-cua-driver.yml:
- Line 1: The .github/workflows/ci-distro-compat-cua-driver.yml file contains
base64-encoded YAML content instead of plain YAML text, which will cause GitHub
Actions to reject the workflow file and prevent it from running. Decode the
entire base64 blob to retrieve the actual YAML content and replace the entire
file with the decoded plain YAML text. This will allow GitHub Actions to
properly parse the workflow configuration and execute the distro-compat matrix
jobs.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 162d9a70-b78a-4702-b2b9-bc5967984d9f

📥 Commits

Reviewing files that changed from the base of the PR and between 3ae0c3f and 66b9342.

📒 Files selected for processing (1)
  • .github/workflows/ci-distro-compat-cua-driver.yml

@@ -0,0 +1 @@
name: "CI: cua-driver distro-compat matrix"

# Smoke-tests the *released* cua-driver binary inside real distro containers
# to catch bugs that the NixOS test suite cannot: glibc ABI floor issues and
# distro-packaging gaps (e.g. Qt5 AT-SPI bridge absent on Ubuntu).
#
# What this catches (the NixOS suite CANNOT catch):
#   1. glibc ABI floor — the released binary is built in a debian:11
#      container (glibc 2.31) so it should run on all of the matrix distros.
#      If someone accidentally bumps the build container to a newer distro the
#      --version smoke-test below will fail on the older glibc distros.
#   2. Runtime library gaps — `doctor` queries the OS for required capabilities
#      (X11, AT-SPI, etc.). If a distro is missing a package the doctor command
#      exits non-zero and prints a human-readable error.
#
# Design principles:
#   - Run the RELEASED binary (downloaded from GitHub Releases), not a freshly
#     built one. This is the only way to catch ABI mismatches because the NixOS
#     CI builds its own binary against NixOS's own glibc.
#   - Keep this fast and cheap: containers + --version/doctor only. Full GUI
#     integration tests stay in nix-build.yml.
#   - Non-blocking by default (continue-on-error: true) — the released binary
#     may not exist yet on a fresh branch; the job is informational until the
#     first linux release tag exists.
#
# Trigger: any PR that touches the Rust cua-driver or this workflow.
# Also runs on push to main and on workflow_dispatch so it works as a
# post-release regression guard.
#
# Companion to nix-build.yml — does NOT replace it. See CUA-599.

on:
  pull_request:
    paths:
      - "libs/cua-driver/rust/**"
      - ".github/workflows/ci-distro-compat-cua-driver.yml"
  push:
    # Run on main (path-filtered) AND on release tags so a newly-published
    # binary is immediately validated against the distro matrix.
    branches: [main]
    tags:
      - "cua-driver-rs-v*"
    paths:
      - "libs/cua-driver/rust/**"
      - ".github/workflows/ci-distro-compat-cua-driver.yml"
  workflow_dispatch:
    inputs:
      version:
        description: "cua-driver-rs version to test (without leading v). Leave blank to auto-detect latest."
        required: false
        default: ""

permissions:
  contents: read

jobs:
  # ── Resolve the binary version to test ───────────────────────────────────────
  # Fetch the latest published cua-driver-rs release tag so individual matrix
  # jobs don't each hit the GitHub API. If workflow_dispatch supplied a version
  # we use that instead.
  resolve-version:
    name: Resolve release version
    runs-on: ubuntu-latest
    outputs:
      version: ${{ steps.pick.outputs.version }}
      binary_url: ${{ steps.pick.outputs.binary_url }}
    steps:
      - name: Pick version
        id: pick
        env:
          GH_TOKEN: ${{ github.token }}
          INPUT_VERSION: ${{ inputs.version }}
        run: |
          if [[ -n "$INPUT_VERSION" ]]; then
            VERSION="$INPUT_VERSION"
          elif [[ "$GITHUB_REF" == refs/tags/cua-driver-rs-v* ]]; then
            VERSION="${GITHUB_REF#refs/tags/cua-driver-rs-v}"
          else
            # Fetch the latest release that matches the cua-driver-rs-v* pattern.
            # The releases are marked prerelease=true so we use /releases instead
            # of /releases/latest (which skips pre-releases).
            VERSION=$(gh api repos/trycua/cua/releases \
              --jq '[.[] | select(.tag_name | startswith("cua-driver-rs-v"))] | first | .tag_name | ltrimstr("cua-driver-rs-v")' \
              2>/dev/null || echo "")
          fi
          if [[ -z "$VERSION" ]]; then
            echo "No cua-driver-rs release found yet — this is expected on a fresh branch."
            echo "version=none" >> "$GITHUB_OUTPUT"
            echo "binary_url=none" >> "$GITHUB_OUTPUT"
          else
            BINARY_URL="https://github.com/trycua/cua/releases/download/cua-driver-rs-v${VERSION}/cua-driver-rs-${VERSION}-linux-x86_64-binary.tar.gz"
            echo "version=$VERSION" >> "$GITHUB_OUTPUT"
            echo "binary_url=$BINARY_URL" >> "$GITHUB_OUTPUT"
            echo "Will test version: $VERSION"
            echo "Binary URL: $BINARY_URL"
          fi

  # ── Per-distro smoke-test matrix ─────────────────────────────────────────────
  # Each job runs in a real distro container, downloads the released binary,
  # and asserts that:
  #   1. The binary executes at all (catches glibc ABI floor regressions).
  #   2. `--version` prints a version string.
  #   3. `doctor` exits 0 (or exits non-zero with a parseable diagnostic —
  #      the doctor command reports capabilities, some may be absent in a
  #      headless container; we treat a clean exit or a known-missing-display
  #      exit as success for the ABI test).
  #
  # Why these distros?
  #   debian:12  — glibc 2.36, representative of Debian stable users
  #   ubuntu:22.04 — glibc 2.35, Ubuntu LTS most widely deployed
  #   ubuntu:24.04 — glibc 2.39, also tests Qt5 AT-SPI bridge gap (see CUA-599)
  #   rockylinux:9 — glibc 2.34, RHEL/Rocky/AlmaLinux users
  #   fedora:41  — glibc 2.40, leading-edge RPM users
  distro-smoke:
    name: "${{ matrix.distro }} (glibc ${{ matrix.glibc_version }})"
    needs: resolve-version
    # Don't block the PR if no release binary exists yet.
    continue-on-error: true
    runs-on: ubuntu-latest
    container:
      image: ${{ matrix.image }}
    strategy:
      fail-fast: false
      matrix:
        include:
          # Debian family
          - distro: "debian:12"
            image: "debian:12"
            glibc_version: "2.36"
            pkg_install: "apt-get update -qq && apt-get install -y --no-install-recommends curl ca-certificates"
          - distro: "ubuntu:22.04"
            image: "ubuntu:22.04"
            glibc_version: "2.35"
            pkg_install: "apt-get update -qq && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends curl ca-certificates"
          - distro: "ubuntu:24.04"
            image: "ubuntu:24.04"
            glibc_version: "2.39"
            pkg_install: "apt-get update -qq && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends curl ca-certificates"
          # RPM family
          - distro: "rockylinux:9"
            image: "rockylinux:9"
            glibc_version: "2.34"
            pkg_install: "dnf install -y --setopt=install_weak_deps=False curl ca-certificates"
          - distro: "fedora:41"
            image: "fedora:41"
            glibc_version: "2.40"
            pkg_install: "dnf install -y --setopt=install_weak_deps=False curl ca-certificates"

    steps:
      - name: Skip if no release binary
        if: needs.resolve-version.outputs.version == 'none'
        run: |
          echo "No cua-driver-rs release binary exists yet. Skipping distro smoke-test."
          echo "This is expected on branches before the first release tag."
          exit 0

      - name: Install curl + ca-certificates
        if: needs.resolve-version.outputs.version != 'none'
        run: ${{ matrix.pkg_install }}

      - name: Download released binary
        if: needs.resolve-version.outputs.version != 'none'
        env:
          BINARY_URL: ${{ needs.resolve-version.outputs.binary_url }}
        run: |
          echo "Downloading: $BINARY_URL"
          curl -fsSL "$BINARY_URL" -o cua-driver.tar.gz
          tar -xzf cua-driver.tar.gz
          chmod +x cua-driver
          ls -lh cua-driver

      - name: Verify glibc floor (ldd)
        if: needs.resolve-version.outputs.version != 'none'
        run: |
          # Print glibc version on this host and the minimum version the binary
          # requires. This makes CI logs self-explanatory if the binary fails.
          echo "=== Host glibc ==="
          ldd --version | head -1 || true
          echo "=== Binary glibc requirements ==="
          # objdump / readelf may not be installed in minimal containers;
          # strings is more universally available.
          strings cua-driver | grep -E "^GLIBC_[0-9]" | sort -V | tail -5 || true

      - name: Smoke-test --version
        if: needs.resolve-version.outputs.version != 'none'
        run: |
          echo "=== cua-driver --version ==="
          # This is the primary ABI-floor gate: if the binary can't even print
          # its version the glibc requirement is too high for this distro.
          ./cua-driver --version
          VERSION_OUT=$(./cua-driver --version)
          echo "Output: $VERSION_OUT"
          # Sanity-check that the output contains a version number.
          if ! echo "$VERSION_OUT" | grep -qE "[0-9]+\.[0-9]+\.[0-9]+"; then
            echo "ERROR: --version output does not contain a semver string"
            exit 1
          fi
          echo "PASS: --version"

      - name: Smoke-test doctor
        if: needs.resolve-version.outputs.version != 'none'
        run: |
          echo "=== cua-driver doctor ==="
          # doctor checks for runtime capabilities (display, AT-SPI, etc.).
          # In a headless container many capabilities will be absent — that's
          # expected and NOT a failure. What we test here is that:
          #   a. The binary loads and runs the doctor subcommand at all.
          #   b. It exits with a parseable status (not a SIGILL / glibc symbol
          #      error which would manifst as exit code 127 or similar).
          set +e
          ./cua-driver doctor 2>&1
          EXIT_CODE=$?
          set -e
          echo "doctor exit code: $EXIT_CODE"
          # Exit codes that indicate glibc/ABI failure (command not found / bad ELF):
          if [[ $EXIT_CODE -eq 127 || $EXIT_CODE -eq 126 ]]; then
            echo "ERROR: cua-driver failed to execute (exit $EXIT_CODE) — likely glibc ABI mismatch"
            exit 1
          fi
          # Treat 0 (all capabilities present) or 1 (capabilities missing but
          # doctor ran) as success — both mean the binary loaded correctly.
          echo "PASS: doctor ran without ABI error"

  # ── Summary job ──────────────────────────────────────────────────────────────
  # A single job that other status checks can require. Marks green when all
  # distro-smoke jobs pass (or when the binary doesn't exist yet and all
  # continue-on-error jobs skipped).
  distro-compat-summary:
    name: "Distro compat summary"
    needs: [resolve-version, distro-smoke]
    if: always()
    runs-on: ubuntu-latest
    steps:
      - name: Check results
        run: |
          echo "resolve-version result: ${{ needs.resolve-version.result }}"
          echo "distro-smoke result:    ${{ needs.distro-smoke.result }}"
          # If resolve-version failed (API error etc.) that's a real failure.
          if [[ "${{ needs.resolve-version.result }}" == "failure" ]]; then
            echo "ERROR: resolve-version job failed"
            exit 1
          fi
          # distro-smoke is continue-on-error so its result is always
          # 'success' even when individual jobs fail. The individual job
          # logs are the source of truth; this summary job just gates
          # the overall workflow status.
          echo "All distro compat checks completed."
 No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Verify the workflow file is valid YAML text instead of a base64 scalar.
# Expectation after the fix: the file starts with YAML such as `name:`, and contains top-level `on:` and `jobs:` keys.

python - <<'PY'
from pathlib import Path
import base64
import binascii

path = Path(".github/workflows/ci-distro-compat-cua-driver.yml")
data = path.read_text().strip()

print("First 120 chars:")
print(data[:120])

try:
    decoded = base64.b64decode(data, validate=True).decode("utf-8")
except (binascii.Error, UnicodeDecodeError):
    print("OK: file is not a single valid base64 blob")
else:
    print("ERROR: file is still base64-encoded. Decoded preview:")
    print(decoded[:500])
    raise SystemExit(1)

text = path.read_text()
missing = [key for key in ("on:", "jobs:") if key not in text]
if missing:
    print(f"ERROR: missing expected workflow keys: {missing}")
    raise SystemExit(1)

print("OK: workflow appears to be plain YAML with expected keys")
PY

Repository: trycua/cua

Length of output: 747


Decode the base64 blob before committing the workflow file.

The file contains base64-encoded YAML instead of plain YAML text. GitHub Actions expects a valid YAML mapping and will reject this file, preventing the distro-compat matrix from running. Replace the entire content with the decoded YAML.

🧰 Tools
🪛 actionlint (1.7.12)

[error] 1-1: "jobs" section is missing in workflow

(syntax-check)


[error] 1-1: "on" section is missing in workflow

(syntax-check)


[error] 1-1: "workflow" section is scalar node but mapping node is expected

(syntax-check)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/ci-distro-compat-cua-driver.yml at line 1, The
.github/workflows/ci-distro-compat-cua-driver.yml file contains base64-encoded
YAML content instead of plain YAML text, which will cause GitHub Actions to
reject the workflow file and prevent it from running. Decode the entire base64
blob to retrieve the actual YAML content and replace the entire file with the
decoded plain YAML text. This will allow GitHub Actions to properly parse the
workflow configuration and execute the distro-compat matrix jobs.

Source: Linters/SAST tools

Adds a GitHub Actions workflow that runs the *released* cua-driver binary
inside real distro containers (debian:12, ubuntu:22.04, ubuntu:24.04,
rockylinux:9, fedora:41) to catch glibc ABI floor regressions and distro
packaging gaps that the NixOS test suite cannot detect.

See CUA-599 for full context.
@r33drichards
r33drichards force-pushed the f/cua-599-nixos-cua-driver-test-suite-has-blind-spots-for-real-distro branch from 66b9342 to 2ef1d21 Compare June 21, 2026 03:21
@r33drichards

Copy link
Copy Markdown
Collaborator Author

✅ Review complete

Review commit 9a39bd73 pushed:

  • Fixed double --version call
  • Added binutils to all 5 distros (needed for strings)
  • Typo fix (manifst → manifest)
  • Clarified GHA push.tags + paths filter behaviour

Follow-up tickets documented in Linear (workspace at issue limit): debian:11 matrix, arm64 jobs, remove continue-on-error.

Ready for merge.

…t on rockylinux:9

The cua-driver binary dynamically links libX11, so running --version in a
minimal container without libX11 fails with exit 127 (missing shared lib).
Add libx11-6 (Debian/Ubuntu) and libX11 (Fedora/Rocky) to the pkg_install
lists so the binary can actually execute.

RockyLinux 9 ships curl-minimal which conflicts with the full curl package.
Add --allowerasing to let dnf replace curl-minimal with curl, matching the
error message's own suggestion.
r33drichards added a commit that referenced this pull request Jun 21, 2026
* ci(cua-driver): add distro-compat smoke-test workflow with X11 runtime deps

Add .github/workflows/ci-distro-compat-cua-driver.yml from PR #1959
(f/cua-599-nixos-cua-driver-test-suite-has-blind-spots-for-real-distro)
with a fix for the X11 runtime dependency issue.

The workflow smoke-tests the released cua-driver-rs binary across 5 distros
(debian:12, ubuntu:22.04, ubuntu:24.04, rockylinux:9, fedora:41) to catch
glibc ABI floor regressions.

**Fix from original PR:** The pkg_install matrix entries now include the
required X11 runtime libs (libx11-6 libxi6 libxtst6 libxext6 on Debian/Ubuntu;
libX11 libXi libXtst libXext on Rocky/Fedora). Without these, the cua-driver
binary fails with exit 127 (dynamic linker cannot resolve libXi.so.6 etc.)
before main() even runs -- which the smoke-test correctly interprets as an
ABI failure.

The cua-driver-rs-v0.5.8 release (published 2026-06-21) provides the binary
assets this workflow downloads. The binary URL pattern matches:
  https://github.com/trycua/cua/releases/download/cua-driver-rs-v{VERSION}/
    cua-driver-rs-{VERSION}-linux-x86_64-binary.tar.gz

Fixes: CUA-606
Related: CUA-599, PR #1959

* ci(cua-driver): fix rocky linux curl conflict in distro-compat workflow

Rocky Linux 9 ships curl-minimal in the base image which conflicts with
the full curl package. Use --allowerasing to let dnf replace curl-minimal
with the full curl package transparently.

* review: add libwayland-client0/libwayland-client runtime dep + fix manifest typo

- Add libwayland-client0 (deb) and libwayland-client (rpm) to pkg_install
  because the CD workflow links against libwayland-dev (native Wayland
  backend, added in #1910); without the runtime lib the dynamic linker
  fails on any distro that doesn't install it by default.
- Fix typo: 'manifst' -> 'manifest' in doctor smoke-test comment.
- Update comment block to mention Wayland alongside X11 deps.

---------

Co-authored-by: OpenClaw <openclaw@trycua.com>
cua-driver links against multiple X11 extension libraries at startup:
libX11, libXi (XInput), libXtst (XTest), libXfixes, libXrandr,
libXcomposite, libXext. Any missing lib causes exit 127 before main()
runs, which looks like a glibc ABI failure but isn't.

Install the full set in pkg_install for both Debian/Ubuntu and RPM
families. Also add an ldd diagnostic step to make future missing-lib
failures immediately obvious in CI logs.
The main branch landed its own fix for the same distro-compat issues
(missing X11 + wayland libs, curl-minimal conflict on Rocky 9). This
merge adopts main's version of those fixes and adds back our ldd
diagnostic step and double-version-call cleanup.
@r33drichards

Copy link
Copy Markdown
Collaborator Author

🏔️ Hillclimb complete

All CI checks are now green on PR #1959.

What was fixed

The ci-distro-compat-cua-driver.yml workflow had two bugs:

  1. Missing X11/Wayland runtime libs — cua-driver dynamically links against X11 extension libs and libwayland at startup. Running ./cua-driver --version in a minimal container without those libs exits with code 127 (missing shared library), which the smoke-test correctly treats as an ABI error. Fixed by adding libx11-6 libxi6 libxtst6 libxext6 libwayland-client0 (Debian/Ubuntu) and libX11 libXi libXtst libXext libwayland-client (Fedora/Rocky) to each distro's pkg_install.

  2. curl conflict on rockylinux:9 — Rocky 9's base image ships curl-minimal which conflicts with the full curl package. Fixed by adding --allowerasing to the dnf install command.

Additionally: removed a duplicate ./cua-driver --version call and added an ldd diagnostic line to the glibc-floor step to make future missing-lib failures immediately obvious in logs.

Final CI run: 27920632568

Job Result
debian:12 (glibc 2.36) ✅ pass
ubuntu:22.04 (glibc 2.35) ✅ pass
ubuntu:24.04 (glibc 2.39) ✅ pass
rockylinux:9 (glibc 2.34) ✅ pass
fedora:41 (glibc 2.40) ✅ pass
Distro compat summary ✅ pass

@r33drichards
r33drichards merged commit d74ad8f into main Jun 21, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants