Skip to content

chore(cua-driver-rs)(uninstall): drop shared-Swift-TCC note from reset hint - #1772

Merged
f-trycua merged 1 commit into
mainfrom
chore/cua-driver-rs-uninstall-drop-swift-tcc-note
May 30, 2026
Merged

chore(cua-driver-rs)(uninstall): drop shared-Swift-TCC note from reset hint#1772
f-trycua merged 1 commit into
mainfrom
chore/cua-driver-rs-uninstall-drop-swift-tcc-note

Conversation

@f-trycua

@f-trycua f-trycua commented May 30, 2026

Copy link
Copy Markdown
Collaborator

What

Remove the parenthetical note from the uninstall closing message's tccutil reset hint:

(Note: com.trycua.driver is shared with the Swift cua-driver. Resetting it clears grants for both backends. If you still use the Swift driver, skip this step and let macOS keep the grants — the next Swift launch will re-use them.)

The tccutil reset Accessibility/ScreenCapture com.trycua.driver commands stay.

Why

With Rust now the default backend (#1768) and Swift relegated to explicit --backend=swift legacy use, the shared-bundle-id caveat is noise for the common uninstall path.

Notes

  • Only uninstall.sh carried this note; uninstall.ps1 never had it.
  • bash -n passes.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Removed outdated information from the uninstall process on macOS.

Review Change Stack

…t hint

The uninstall closing message's tccutil reset hint carried a parenthetical
warning that com.trycua.driver is shared with the Swift cua-driver and that
resetting clears grants for both backends. With Rust now the default backend
and Swift relegated to explicit --backend=swift legacy use, the note is noise
for the common path. Drop it; keep the tccutil reset commands.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented May 30, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview May 30, 2026 8:35pm

Request Review

@coderabbitai

coderabbitai Bot commented May 30, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b99913d8-1204-4c2b-bfc9-e25d9fbc794e

📥 Commits

Reviewing files that changed from the base of the PR and between f31e720 and 158f2ab.

📒 Files selected for processing (1)
  • libs/cua-driver/scripts/uninstall.sh

📝 Walkthrough

Walkthrough

The uninstall script's macOS --reset-tcc flow removes a parenthetical note explaining that the com.trycua.driver bundle is shared with the retired Swift driver. The closing instructions and TCC reset commands remain in place.

Changes

Uninstall message cleanup

Layer / File(s) Summary
TCC reset message note removal
libs/cua-driver/scripts/uninstall.sh
The parenthetical note about com.trycua.driver being shared with the Swift backend is removed from the macOS Rust uninstall --reset-tcc closing message.

Possibly related PRs

  • trycua/cua#1723: Both PRs touch the same libs/cua-driver/scripts/uninstall.sh Rust-uninstall text/comments about the com.trycua.driver shared bundle-path with the retired Swift driver (one removes the parenthetical note; the other rewords related comment text to avoid bash 3.2 parsing issues).
  • trycua/cua#1738: Both PRs touch libs/cua-driver/scripts/uninstall.sh's macOS/Linux uninstall user-facing output/flow, so the changes overlap at that script's completion messaging logic.
  • trycua/cua#1759: The main PR's change to libs/cua-driver/scripts/uninstall.sh (removing the shared-Swift-driver parenthetical note) directly overlaps with this PR, which introduced that same messaging around the com.trycua.driver TCC reset flow.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A note once lived in parentheses,
Explaining bonds with retired breeze—
'Twas shared with Swift, now gone away,
So out it hops to clearer day!
hops away 🐰

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/cua-driver-rs-uninstall-drop-swift-tcc-note

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@f-trycua
f-trycua merged commit 6036ab4 into main May 30, 2026
6 of 7 checks passed
@f-trycua
f-trycua deleted the chore/cua-driver-rs-uninstall-drop-swift-tcc-note branch May 30, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant