-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(cua-driver-rs)(macos): permissions UX — source labeling + live probe + permissions status|grant CLI verb
#1765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: trycua/cua
Length of output: 21994
Don’t collapse ScreenCaptureKit probe errors into
falsescreen_recording_capturable()turns anySCShareableContent::get()error intofalse(unwrap_or(false)), so transient probe failures are indistinguishable from a true permission miss;invoke()can then emit the “reads granted but a live capture probe failed” warning and serializescreen_recording_capturable: false. (libs/cua-driver/rust/crates/platform-macos/src/tools/check_permissions.rs:21-26, 145-165)sourcesetsresponsible_ppidtolibc::getppid()(immediate parent PID). If the intent is the LaunchServices/TCC “responsible process” PID, this can be wrong for indirect spawn/reparenting cases—rename or add the accurate identity. (40-75)Possible fix
🤖 Prompt for AI Agents