Skip to content

fix(screenshot): apply maxImageDimension cap to match get_window_state #1691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hippoley wants to merge 1 commit into from
Closed

fix(screenshot): apply maxImageDimension cap to match get_window_state #1691

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion libs/cua-driver/swift/Sources/CuaDriverServer/Tools/ScreenshotTool.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,17 @@ public enum ScreenshotTool {
}

do {
// Load config so we can apply the same maxImageDimension cap
// that get_window_state uses. Without this, screenshot returns
// native Retina resolution (2× logical) while click coordinates
// are calibrated against the downscaled image — causing every
// click to miss its target on Retina displays (issue #1592).
let config = await ConfigStore.shared.load()
let shot = try await capture.captureWindow(
windowID: windowID,
format: format,
quality: quality
quality: quality,
maxImageDimension: config.maxImageDimension
)
let base64 = shot.imageData.base64EncodedString()
let mime = format == .png ? "image/png" : "image/jpeg"
Expand Down