Skip to content

fix(cua-driver-rs)(install): rename-out-of-way locked binary before Copy-Item in install-local.ps1 #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
f-trycua merged 1 commit into from
May 24, 2026
+33 −2
Merged

fix(cua-driver-rs)(install): rename-out-of-way locked binary before Copy-Item in install-local.ps1 #1687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 33 additions & 2 deletions libs/cua-driver/scripts/install-local.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,10 +161,41 @@ if (-not (Test-Path -LiteralPath $BuiltBinary)) {

$VersionTag = "0.0.0-local-$Config"
$VersionedDir = Join-Path $ReleasesDir "$VersionTag-$Target"
$DestBinary = Join-Path $VersionedDir $BinaryName

# If a previous install-local left a binary here and it's currently
# being executed (typical: `cua-driver autostart kick` spawned a
# High-IL daemon at logon, which we can't terminate from this
# Medium-IL shell without UAC), the Copy-Item below fails with
# "The process cannot access the file ... because it is being used by
# another process." Windows DOES allow renaming a locked .exe — the
# loader opens images with FILE_SHARE_DELETE, so a rename succeeds
# while the content stays locked. Renaming out of the way frees up
# the destination path so Copy-Item lands cleanly. The old file gets
# unlinked at the next reboot or when the daemon exits.
if (Test-Path -LiteralPath $DestBinary) {
$ts = (Get-Date).ToString('yyyyMMdd-HHmmss')
$stale = "$DestBinary.stale-$ts"
try {
Move-Item -LiteralPath $DestBinary -Destination $stale -Force -ErrorAction Stop
Write-Step "renamed locked previous binary to $(Split-Path -Leaf $stale)"
} catch {
Write-Host "Note: could not rename previous binary at $DestBinary." -ForegroundColor Yellow
Write-Host " ($($_.Exception.Message))" -ForegroundColor Yellow
Write-Host " Most likely a running cua-driver daemon is holding it." -ForegroundColor Yellow
Write-Host " Stop it first (e.g. ``schtasks /End /TN cua-driver-serve`` then re-run)." -ForegroundColor Yellow
}
# Best-effort GC of stale-* siblings older than this run. Cheap;
# keeps the dir from growing unbounded over many re-builds.
Get-ChildItem -LiteralPath $VersionedDir -Filter "$BinaryName.stale-*" -ErrorAction SilentlyContinue |
Where-Object { $_.LastWriteTime -lt (Get-Date).AddDays(-1) } |
ForEach-Object { try { Remove-Item -LiteralPath $_.FullName -Force -ErrorAction SilentlyContinue } catch {} }
}

Write-Step "staging into $VersionedDir"
New-Item -ItemType Directory -Path $VersionedDir -Force | Out-Null
Copy-Item -LiteralPath $BuiltBinary -Destination (Join-Path $VersionedDir $BinaryName) -Force
$installedBinary = Join-Path $VersionedDir $BinaryName
Copy-Item -LiteralPath $BuiltBinary -Destination $DestBinary -Force
$installedBinary = $DestBinary

# Stage the skill pack alongside the binary. install-local mirrors what
# install.ps1 does from a release zip — copies Skills/cua-driver-rs/ from
Expand Down
Loading