fix(cua-driver-rs): rename agent-cursor overlay namespace TropeCUA → Cua - #1656
Conversation
The transparent agent-cursor overlay window registers a Win32 class + title under the namespace `TropeCUA.AgentCursorOverlay` — a leaked codename from an early C# reference implementation that nobody outside the original team would recognise. Renaming to `Cua.AgentCursorOverlay`: - Matches the install-path convention introduced in PR #1644 (`%LOCALAPPDATA%\Programs\Cua\cua-driver\`). - Matches PascalCase Windows-class-name convention. - Gives users a recognisable `Cua.*` namespace when they see the window in EnumWindows / Spy++ / Task Manager — instead of "what's a TropeCUA?". - Cross-platform consistency: Linux overlay's X11 WM_NAME mirrors the same string, so the rename applies to both platforms. ## Surfaced During the cuademo dogfood (running `EnumWindows` against the daemon's pid as part of #1645 hidden-window verification) — saw `TropeCUA.AgentCursorOverlay.default` listed as a visible top-level window owned by cua-driver. The window is intentional (it's the transparent click-through cursor visualization) but the name was confusing. User asked for a namespace that reflects the trycua org. ## Files touched - `crates/platform-windows/src/overlay.rs` — registered class + title - `crates/platform-linux/src/overlay.rs` — X11 WM_NAME - `crates/platform-windows/examples/overlay_dump.rs` — `FindWindowW` class match (matches the registered class so the example still resolves the overlay HWND after this rename) ## Compat The class + title strings aren't part of any public API — they're window-identification metadata visible via EnumWindows. External tools hard-coding the `TropeCUA.*` string would break (we don't know of any). The agent-cursor MCP tools (`set_agent_cursor_enabled`, etc.) reference the overlay by `cursor_id`, not by class/title — unaffected. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe overlay window identifier namespace is renamed from ChangesOverlay Window Namespace Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
The transparent agent-cursor overlay window registers under the namespace `TropeCUA.AgentCursorOverlay` — a leaked codename from an early C# reference impl. Renaming to `Cua.AgentCursorOverlay`:
Surfaced
During cuademo dogfood — `EnumWindows` against the daemon's pid listed `TropeCUA.AgentCursorOverlay.default` as a visible top-level window. The window is intentional (transparent click-through cursor visualization) but the name confused the user.
Files touched
Compat
Class + title strings are window-metadata, not public API. No known external tools depend on the `TropeCUA.*` string. Agent-cursor MCP tools reference the overlay by `cursor_id`, not class/title — unaffected.
🤖 Generated with Claude Code
Summary by CodeRabbit