fix(cua-driver-rs)(dev): install-local.ps1 mirrors install.ps1 param surface + v0.2.14+ paths - #1655
Conversation
…surface + v0.2.14+ paths Dev-script polish so the local-build install loop matches what end users experience. Two changes: 1. **Path defaults**: switch the visible bin dir and package home defaults to v0.2.14+ layout (`Programs\Cua\cua-driver` + `~/.cua-driver`). Previously install-local.ps1 was still using the legacy `trycua\cua-driver-rs` paths, which meant local-build installs landed in a different location than what install.ps1 produces — and the `current` junction couldn't flip between them. 2. **Param surface mirrors install.ps1**: drop the `-Release` switch (which conflicted in meaning with install.ps1's `-Release "<version>"` tag selector — confusing for anyone bouncing between the two scripts) and always build release-mode (matches what install.ps1 hands users — the GitHub Releases zip is `--release`). Add `-NoPathUpdate` switch + corresponding User-PATH update step (also writes $env:Path in the current shell so cua-driver resolves immediately, matching PR #1652 / #1651's behavior). Keep `-AutoStart` as-is. Final param surface: `-AutoStart`, `-NoPathUpdate` — exact subset of install.ps1's user-facing params. If a dev wants a debug build for faster compile iteration, invoke `cargo build -p cua-driver` and use target\debug\cua-driver.exe directly. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesLocal installer script update
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Dev-script polish so the local-build install loop matches what end users experience via `install.ps1`.
Two changes in `scripts/install-local.ps1`:
Path defaults updated to v0.2.14+ layout:
/.cua-driver-rs` → `/.cua-driver`Without this, local-build installs landed at the LEGACY paths while `install.ps1` produces the new paths — the `current` junction couldn't flip between them.
Param surface mirrors `install.ps1`:
Final param surface: `-AutoStart`, `-NoPathUpdate` — exact subset of install.ps1's user-facing params. If a dev wants a debug build for faster compile iteration, invoke `cargo build -p cua-driver` directly and use `target\debug\cua-driver.exe`.
Why dev-only
`install-local.ps1` is not used by end users (`irm install.ps1 | iex` fetches a built release). This change makes the dev iteration loop cleaner: edit Rust source, run `install-local.ps1`, get a binary at the SAME paths the real install would produce. No more "wait, why is my local build in `trycua\cua-driver-rs` while my release install is in `Cua\cua-driver`?".
Test plan
%LOCALAPPDATA%\\Programs\\Cua\\cua-driver\\bin\\cua-driver.execurrentjunction to the fresh build (atomic upgrade)-NoPathUpdateskips the PATH write-AutoStartregisters the cua-driver-serve task🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
-NoPathUpdateparameter to control whether installation modifies the system PATH.Chores