-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Avoid native side effects during computer-server imports #1569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
0xjohnnydev
wants to merge
2
commits into
chore/python-import-format-baseline
from
fix/computer-server-import-safety
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import os | ||
| import platform | ||
| import subprocess | ||
| import sys | ||
|
|
||
| import pytest | ||
|
|
||
|
|
||
| def _assert_import_exits_cleanly(import_statement: str): | ||
| env = os.environ.copy() | ||
| for key in ("CUA_BACKEND", "CUA_VNC_HOST", "CUA_VNC_PORT", "CUA_VNC_PASSWORD"): | ||
| env.pop(key, None) | ||
|
|
||
| result = subprocess.run( | ||
| [sys.executable, "-X", "faulthandler", "-c", f"{import_statement}; print('ok')"], | ||
| capture_output=True, | ||
| env=env, | ||
| text=True, | ||
| timeout=20, | ||
| ) | ||
|
|
||
| assert result.returncode == 0, result.stdout + result.stderr | ||
| assert "ok" in result.stdout | ||
|
|
||
|
|
||
| def test_package_import_does_not_import_native_handlers_at_teardown(): | ||
| _assert_import_exits_cleanly("import computer_server") | ||
|
|
||
|
|
||
| def test_generic_handler_import_does_not_import_native_handlers_at_teardown(): | ||
| _assert_import_exits_cleanly("import computer_server.handlers.generic") | ||
|
|
||
|
|
||
| @pytest.mark.skipif(platform.system() != "Darwin", reason="macOS handler requires AppKit") | ||
| def test_macos_handler_creation_exits_cleanly_at_teardown(): | ||
| _assert_import_exits_cleanly( | ||
| "from computer_server.handlers.factory import HandlerFactory; " | ||
| "HandlerFactory.create_handlers()" | ||
| ) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isolate subprocess env to prevent flaky import-safety tests.
Line 9 currently inherits the parent environment, so pre-set
CUA_BACKEND/CUA_VNC_*can alterHandlerFactory.create_handlers()and fail this test for non-import-safety reasons.🔧 Suggested fix
🤖 Prompt for AI Agents