feat(cua-driver): consolidate type_text; remove get_accessibility_tree - #1416
Merged
Conversation
type_text now auto-falls back to CGEvent character synthesis when the AX write is rejected — covers Chromium/Electron inputs without requiring the caller to choose between two tools. Adds delay_ms param (default 30ms, used only in the CGEvent path). TypeTextCharsTool deleted; all references updated to type_text throughout docs, skills, and tests. get_accessibility_tree removed — its functionality (running apps + window list) is fully covered by list_apps and list_windows. Tool file deleted, removed from ToolRegistry, stale doc references updated to list_windows. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
6 tasks
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (13)
📝 WalkthroughWalkthroughThis PR consolidates typing functionality by removing Changes
Sequence Diagram(s)sequenceDiagram
participant Client as Client
participant TypeTextHandler as TypeTextTool Handler
participant AXInput as AXInput
participant KeyboardInput as KeyboardInput
participant System as OS
Client->>TypeTextHandler: type_text(element_index, text, delay_ms)
TypeTextHandler->>AXInput: Try setAttribute("AXSelectedText")
alt AX Success
AXInput->>TypeTextHandler: Success
TypeTextHandler->>Client: ✓ Text inserted via AX
else AX Fails
AXInput->>TypeTextHandler: AXInputError
TypeTextHandler->>KeyboardInput: typeCharacters(text, pid, delay_ms)
KeyboardInput->>System: CGEvent.postToPid (per-character)
System->>KeyboardInput: Events posted
KeyboardInput->>TypeTextHandler: Success
TypeTextHandler->>Client: ✓ Text inserted via CGEvent (AX fallback)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
7 tasks
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
type_textconsolidationtype_text_charsis deleted.type_textnow auto-falls back to CGEvent character synthesis (CGEvent.postToPid) when the AX attribute write is rejected — covers Chromium/Electron inputs transparently.delay_msparam (0–200, default 30ms) controls inter-character delay in the CGEvent fallback path; ignored when the AX path succeeds.via AXorvia CGEvent (AX fallback)).get_accessibility_treeremovallist_appsandlist_windows.list_windows.Test plan
swift buildclean ✅type_texton a Cocoa text field → summary saysvia AXtype_texton a Chrome input → falls back to CGEvent, summary saysvia CGEvent (AX fallback)cua-driver get_accessibility_tree→Unknown toolerrorlist_appsandlist_windowsstill work🤖 Generated with Claude Code
Summary by CodeRabbit
Removed Features
type_text_charsandget_accessibility_treetoolsImprovements
type_texttool now automatically handles typing in Chromium and Electron applications with seamless fallbackdelay_msparameter totype_textfor controlling fallback timing (0-200ms, default 30ms)Bug Fixes