Skip to content

perf(cua-driver): use on-screen-only SCShareableContent query for permission probe #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
octo-patch wants to merge 1 commit into from
Closed

perf(cua-driver): use on-screen-only SCShareableContent query for permission probe #1378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions libs/cua-driver/Sources/CuaDriverCore/Permissions/Permissions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,13 @@ public enum Permissions {
///
/// Accessibility uses `AXIsProcessTrusted()` — reliable.
///
/// Screen Recording does a real probe via `SCShareableContent.current`
/// Screen Recording does a real probe via
/// `SCShareableContent.excludingDesktopWindows(_:onScreenWindowsOnly:)`
/// rather than `CGPreflightScreenCaptureAccess()` — the latter returns
/// false negatives for subprocess-launched apps, even when the grant is
/// active. The probe costs ~100-300ms but returns the truth.
/// active. Limiting the query to on-screen windows avoids the multi-second
/// stall caused by `SCShareableContent.current` enumerating thousands of
/// off-screen windows (e.g. from a crashed system process).
public static func currentStatus() async -> PermissionsStatus {
async let screen = probeScreenRecording()
return await PermissionsStatus(
Expand Down Expand Up @@ -54,7 +57,15 @@ public enum Permissions {

private static func probeScreenRecording() async -> Bool {
do {
_ = try await SCShareableContent.current
// Prefer the on-screen-only variant over `SCShareableContent.current`.
// The latter must resolve app names for every window — including
// thousands of off-screen windows left by crashed system processes —
// which can stall for several seconds on affected machines.
// The lighter query still throws `SCStreamError.userDeclined` when
// the Screen Recording TCC grant is absent, so it is equally
// reliable as a permission probe.
_ = try await SCShareableContent.excludingDesktopWindows(
false, onScreenWindowsOnly: true)
return true
} catch {
return false
Expand Down