Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

558 trycourierreact preferences cannot find module date fnsformat in v510 #559

Conversation

bwebs
Copy link
Contributor

@bwebs bwebs commented Apr 5, 2024

Description

Add date-fns dependency to react-preferences package

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fixes #558

@bwebs bwebs enabled auto-merge (rebase) April 5, 2024 17:07
@bwebs bwebs requested a review from suhasdeshpande April 5, 2024 17:08
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@c05d7c0). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #559   +/-   ##
=======================================
  Coverage        ?   35.31%           
=======================================
  Files           ?       72           
  Lines           ?     1243           
  Branches        ?      384           
=======================================
  Hits            ?      439           
  Misses          ?      804           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bwebs bwebs disabled auto-merge April 5, 2024 17:38
@bwebs bwebs merged commit c7d776f into main Apr 5, 2024
7 checks passed
@bwebs bwebs deleted the 558-trycourierreact-preferences-cannot-find-module-date-fnsformat-in-v510 branch April 5, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

@trycourier/react-preferences Cannot find module "date-fns/format" in v5.1.0
2 participants