Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing extra channels and exposing customize on Required topics #555

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

bwebs
Copy link
Contributor

@bwebs bwebs commented Mar 28, 2024

Description

  • When using Customize Delivery Channel, the default would put all options selected even if the defaults had less options.
  • When a topic was required, we wouldn't show Customize Delivery Channel at all. Now, we will show it, but not let you de-select all channels.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix [#1]()

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@95e8a5f). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #555   +/-   ##
=======================================
  Coverage        ?   35.95%           
=======================================
  Files           ?       70           
  Lines           ?     1196           
  Branches        ?      365           
=======================================
  Hits            ?      430           
  Misses          ?      766           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bwebs bwebs merged commit d29fb4c into main Apr 16, 2024
7 checks passed
@bwebs bwebs deleted the bryan/customize-delivery-required-topic branch April 16, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants