Skip to content

fixing read and unread logic to include new type of IGetInboxMessagesParams.status #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

bwebs
Copy link
Contributor

@bwebs bwebs commented Feb 16, 2024

When using Inbox with views, unread and read weren't getting applied properly. This PR fixes that by applying the GetInboxMessagesParams.status to fetchMessages()

Description

[Pull Request Description Here]

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@bwebs bwebs requested a review from rileylnapier February 16, 2024 19:54
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@aabbe8d). Click here to learn what that means.

Files Patch % Lines
...ackages/react-hooks/src/inbox/use-inbox-actions.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #544   +/-   ##
=======================================
  Coverage        ?   35.92%           
=======================================
  Files           ?       70           
  Lines           ?     1197           
  Branches        ?      366           
=======================================
  Hits            ?      430           
  Misses          ?      767           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bwebs bwebs merged commit 082f191 into main Feb 16, 2024
@bwebs bwebs deleted the bryan/fetchmessages-read-unread branch February 16, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants