Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C-9943] fixes inbox preferences Opted Out by default #471

Merged

Conversation

suhasdeshpande
Copy link
Contributor

Description

[Pull Request Description Here]

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix [#1]()

@linear
Copy link

linear bot commented Jul 15, 2023

C-9943 Courier Inbox Preferences Opted Out by Default

Detailed Description

Oyster is looking to implement the Courier Inbox channel into preferences and has run into an issue where the inbox channel is opted-out by default when updating the channel selection settings. The hosted page preview will show the Inbox channel as opted out by default.

Background:

https://www.loom.com/share/bf160cb71ceb4381a53ad4d512581c2f?sid=7a3507e8-cbca-471d-b85d-436a6be45e35

Steps to reproduce (if an issue/bug):

  • Create a notification with inbox channel
  • add it to subscription topic
  • customize delivery channels for the section to include inbox
  • publish and preview
  • inbox is opted out by default.

Who are the stakeholders (customers, other teams/functions etc)

  • Oyster
  • ProducePay
  • customers using inbox and preferences

Any Follow-ups required (customer communication, slack ACK, etc)

https://trycourier.slack.com/archives/C03JAUABHA8/p1689182631480319

@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@15c6f47). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #471   +/-   ##
=======================================
  Coverage        ?   40.92%           
=======================================
  Files           ?       67           
  Lines           ?     1036           
  Branches        ?      307           
=======================================
  Hits            ?      424           
  Misses          ?      612           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@misabel misabel enabled auto-merge (rebase) July 18, 2023 04:07
@misabel misabel merged commit 183b206 into main Jul 18, 2023
@misabel misabel deleted the suhas/c-9943-courier-inbox-preferences-opted-out-by-default branch July 18, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants